Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable19] dont hold a transaction during the move to trash #23186

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[stable19] dont hold a transaction during the move to trash #23186

merged 1 commit into from
Oct 6, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 5, 2020 •
edited by nickvergessen
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #23109

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.4 milestone Oct 5, 2020
@icewind1991 @nickvergessen
dont hold a transaction during the move to trash
f6bf519 
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues

Signed-off-by: Robin Appelman <robin@icewind.nl>
@nickvergessen nickvergessen force-pushed the backport/23109/stable19 branch from f8bf210 to f6bf519 Compare October 5, 2020 13:27
nickvergessen
nickvergessen approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the backport

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2020
@MorrisJobke
Copy link
Member

19.0.4 or 19.0.5 due to RC phase? cc @rullzer

@MorrisJobke MorrisJobke merged commit c75378a into stable19 Oct 6, 2020
@MorrisJobke MorrisJobke deleted the backport/23109/stable19 branch October 6, 2020 07:11
@MorrisJobke
Copy link
Member

Got this during the RC testing and quite some positive testing feedback so this is for 19.0.4

@rullzer rullzer mentioned this pull request Oct 6, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: trashbin
Projects
None yet
Milestone
Nextcloud 19.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @nickvergessen @juliusknorr @icewind1991