dont hold a transaction during the move to trash #23109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991 should this fix the deadlock things? |
|
Yes |
nickvergessen
approved these changes
Oct 5, 2020
|
/backport to stable20 |
|
/backport to stable19 |
This was referenced Oct 5, 2020
This was referenced Oct 5, 2020
|
@nickvergessen I just appied the fix and still nothing getting the errors when deleting? or is the fix still being worked on?
|
|
I can confirm this does not fix #22482 on 19.0.3. |
|
can we also get a backport to stable18? |
|
hello any updates on this and the DeadlockException executing UPDATE |
|
/backport to stable18 |
|
Also confirm that this does not fix the Deadlock issue. Any updates on this? |
|
Also facing the same issue on version 19.05, running a occ filles:cleanup. My oc_filecache table is using 4Gb of space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues
Signed-off-by: Robin Appelman robin@icewind.nl