Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Set fileInfo correctly for LegacyTabs #20588

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[stable18] Set fileInfo correctly for LegacyTabs #20588

merged 1 commit into from
Apr 23, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 21, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #20564

@backportbot-nextcloud backportbot-nextcloud bot added bug feature: file sidebar Related to the file sidebar component labels Apr 21, 2020
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.4 milestone Apr 21, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 21, 2020
Merged
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 21, 2020
@go2sh @npmbuildbot
Set fileInfo correctly for LegacyTabs
185f867 
Watch for changes of the fileInfo prop and propagate it to,
the underlying component.

Fixes #20106.

Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/20564/stable18 branch from 8313bbb to 185f867 Compare April 21, 2020 13:04
MorrisJobke
MorrisJobke approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 21, 2020
@MorrisJobke MorrisJobke merged commit 4bcbeff into stable18 Apr 23, 2020
@MorrisJobke MorrisJobke deleted the backport/20564/stable18 branch April 23, 2020 12:37
@rullzer rullzer mentioned this pull request May 21, 2020
Merged
5 tasks
@kesselb
Copy link
Contributor

kesselb commented Jun 6, 2020

Seems to break the sidebar for activity and comments: #21239

@go2sh
Copy link
Contributor

go2sh commented Jun 6, 2020

I'll check it tonight.

@go2sh
Copy link
Contributor

go2sh commented Jun 6, 2020

@kesselb I depends. ^^ This commit fixed some stuff with the reactivity of the tabs enabling the watching of the fileInfo prop. But reverting the commit restores the old bug. I'am not sure how to proceed. @skjnldsv

@go2sh
Copy link
Contributor

go2sh commented Jun 7, 2020

So I see two possible fixes: 1) Revert this and set the fileInfo when opening the sidebar. (like the views) 2) Backport the reactivity fixes into the old nextcloud-vue branch.

@go2sh go2sh mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@go2sh go2sh go2sh approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component
Projects
None yet
Milestone
Nextcloud 18.0.5
Development

Successfully merging this pull request may close these issues.
6 participants
@skjnldsv @kesselb @go2sh @MorrisJobke @juliusknorr @rullzer