Wiswedel/inherited shares/design polishing #18447
Conversation
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
|
/compile amend / |
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
d1e7167 to
f4f69da
Compare
|
@wiswedel cool, thanks! Could you add screenshots for quicker design review? Thanks! :) |
|
| </ActionText> | ||
| <ActionLink v-if="share.fileSource" | ||
| icon="icon-folder" | ||
| :href="fileTargetUrl"> | ||
| {{ t('files_sharing', 'Open folder') }} | ||
| {{ t('files_sharing', 'Via folder') }} |
There was a problem hiding this comment.
"Via parent folder" would be clearer, as per #18202
There was a problem hiding this comment.
I don't really like either.
- "Parent folder" implies parent of the one I'm currently in to me.
- "Via folder" is also kind of bumpy wording.
@jancborchardt Do you have any other smart ideas?
There was a problem hiding this comment.
Then say "Via foldername", actually naming the folder in question. :)
If that is not possible, "Via parent folder" is the best compromise between concise and informative atm. We can always enhance this later.
There was a problem hiding this comment.
Via
foldername
I like that - however, that's where my vue half knowledge ends. Can you help me retrieving that folder name @jancborchardt ?
There was a problem hiding this comment.
No, I likely have even less knowledge there. :) @skjnldsv @juliushaertl?
|
Looking nice! See the comment on the wording, and if we also get "icon-close" for the Unshare action then it’s as per spec in the issue and good to go. :) |
icon-close contradicts with the normal unshare icon
|
Yes, we said this should be done in a dedicated pr |
Yeah, let's do both then in a separate PR, but not have inconsistencies in the meantime. |
resolves #18202
Signed-off-by: Sascha Wiswedel sascha.wiswedel@nextcloud.com