Inherited shares design review

[skjnldsv]

Design review :)

• Main row text should be either only "Others with access", or "4 others with access" with the number prepended: decision is to never show the number
• Agree with @rullzer, let’s use "Added by" instead of "Invited by", better language
• "Open folder" is a bit confusing as it’s unclear what it does. It opens the parent folder which this person got shared. Can we just write the folder name here, as per the mockup? If that’s not possible, we should write "Via parent folder".

For another pr as we should change all the other sharing entries using this wording & icon

• "Delete share" sounds like it deletes some content. Can it be "Unshare"
• Also, can it have the icon-close as icon instead of the delete icon?

Answering your questions @skjnldsv

Should the "open folder" action open in a newt tab?

Yes, probably.

Should we display inherited shares that are exactly the opened folder ? (e.g I can currently see shares of the folder 123 when opening the list of inherited shares on the folder 123)

No? Cause they are just shares, not inherited shares? Or do I misunderstand?

Originally posted by @jancborchardt in #15952 (comment)

[wiswedel]

Main row text should be either only "Others with access", or "4 others with access" with the number prepended: decision is to never show the number

Please make sure to align this with https://github.com/rullzer/sharelisting/

[jancborchardt]

(Just btw and for future reference if we ever include the number again: There is no space before a ":" colon. :)

[skjnldsv]

Sorry, french habits :p

[skjnldsv]

Followup in #18477