Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "Unshare" instead of "Delete share" for the sharing sidebar #18477

Closed
2 tasks
skjnldsv opened this issue Dec 19, 2019 · 1 comment · Fixed by #18563
Closed
2 tasks

Use "Unshare" instead of "Delete share" for the sharing sidebar #18477

skjnldsv opened this issue Dec 19, 2019 · 1 comment · Fixed by #18563
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: file sidebar Related to the file sidebar component feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 18.0.0

Comments

@skjnldsv
Copy link
Member

Follow up of #18202

  • "Delete share" sounds like it deletes some content. Can it be "Unshare"
  • Also, can it have the icon-close as icon instead of the delete icon?
@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of feature: sharing papercut Annoying recurring issue with possibly simple fix. feature: file sidebar Related to the file sidebar component labels Dec 19, 2019
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Dec 19, 2019
@skjnldsv skjnldsv mentioned this issue Dec 19, 2019
Closed
5 tasks
@gary-kim gary-kim added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Dec 19, 2019
@gary-kim
Copy link
Member

gary-kim commented Dec 19, 2019 •
edited
Loading

Just need to change the options here then run make.

server/apps/files_sharing/src/components/SharingEntryLink.vue

Lines 259 to 264 in f87a71c

<ActionButton v-if="share.canDelete"
icon="icon-delete"
:disabled="saving"
@click.prevent="onDelete">
{{ t('files_sharing', 'Delete share') }}
</ActionButton>

@alexandregv alexandregv mentioned this issue Dec 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: file sidebar Related to the file sidebar component feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging a pull request may close this issue.

Clarify "Delete share" action in sharing sidebar
2 participants
@skjnldsv @gary-kim