Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Add pipe mode for sendmail #12749

Merged
merged 1 commit into from
Dec 10, 2018
Merged

[stable14] Add pipe mode for sendmail #12749

merged 1 commit into from
Dec 10, 2018

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 29, 2018 •
edited
Loading

(squashed) backport of #12424

@ChristophWurst ChristophWurst added this to the Nextcloud 14.0.5 milestone Nov 29, 2018
@ChristophWurst ChristophWurst self-assigned this Nov 29, 2018
rullzer
rullzer approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

MorrisJobke
MorrisJobke approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

Restarted CI: https://drone.nextcloud.com/nextcloud/server/13482

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 7, 2018
@kesselb kesselb force-pushed the backport/12424/stable14 branch from 44cd8ec to 876ee05 Compare December 8, 2018 16:14
@cwiedmann @kesselb
Apply patch from @cwiedmann but drop -oi option for pipe
571e3c1 
* Add sendmailmode to gui
* Add testcases for pipe mode

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the backport/12424/stable14 branch from 876ee05 to 571e3c1 Compare December 8, 2018 16:18
@kesselb kesselb added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 8, 2018
@kesselb
Copy link
Contributor

kesselb commented Dec 8, 2018

Fixed failing unit tests (876ee05), rebased and signed-off.

@kesselb kesselb removed their request for review December 8, 2018 16:30
@ChristophWurst ChristophWurst merged commit 26a5b6d into stable14 Dec 10, 2018
@ChristophWurst ChristophWurst deleted the backport/12424/stable14 branch December 10, 2018 08:46
@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 14.0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @MorrisJobke @kesselb @rullzer @cwiedmann