Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipe mode for sendmail #12424

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Add pipe mode for sendmail #12424

merged 3 commits into from
Nov 29, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Nov 12, 2018 •
edited
Loading

Based on #11454
Close #11281

  • Removed -oi from pipe mode (i'm unsure if the switch is available on any platform)
  • Value can be changed on settings page

image

cc @cwiedmann @duke-m

@kesselb kesselb added this to the Nextcloud 16 milestone Nov 12, 2018
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 12, 2018
This was referenced Nov 12, 2018
Closed
Closed
rullzer
rullzer approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test. But makes sense.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2018
@kesselb
Copy link
Contributor Author

kesselb commented Nov 28, 2018

I will have a look at the failed tests later.

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 28, 2018
@kesselb kesselb force-pushed the feature/add-pipe-mode-for-sendmail branch from 70a8396 to e84fcc3 Compare November 28, 2018 19:08
@kesselb
Copy link
Contributor Author

kesselb commented Nov 28, 2018

@rullzer @MorrisJobke mind to review again? Tests are working for me now.

cwiedmann and others added 3 commits November 29, 2018 16:02
@cwiedmann @kesselb
Apply patch from @cwiedmann but drop -oi option for pipe
446d96f 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Add sendmailmode to gui
92675a6 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Add testcases for pipe mode
4a2c56b 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the feature/add-pipe-mode-for-sendmail branch from 1b46f04 to 4a2c56b Compare November 29, 2018 15:02
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2018
ChristophWurst
ChristophWurst approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't test but code looks good!

MorrisJobke
MorrisJobke approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit ee2cb46 into master Nov 29, 2018
@MorrisJobke MorrisJobke deleted the feature/add-pipe-mode-for-sendmail branch November 29, 2018 16:43
@MorrisJobke
Copy link
Member

/backport to stable15

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2018
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #12736

@MorrisJobke
Copy link
Member

/backport to stable14

@backportbot-nextcloud
Copy link

The backport to stable14 failed. Please do this backport manually.

@ChristophWurst ChristophWurst mentioned this pull request Nov 29, 2018
Merged
@krauthosting krauthosting mentioned this pull request Nov 11, 2021
Closed
@kesselb kesselb mentioned this pull request Jul 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @MorrisJobke @rullzer @ChristophWurst @cwiedmann