Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LDAP] The WebUI Wizard also should not assign empty config IDs #10820

Merged
merged 1 commit into from
Aug 24, 2018
Merged

[LDAP] The WebUI Wizard also should not assign empty config IDs #10820

merged 1 commit into from
Aug 24, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Aug 23, 2018 •
edited
Loading

With 689df9a the behaviour to assign only non-empty config IDs was introduced. Only, this was only effective for CLI and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes #5094.

@blizzz blizzz added bug 3. to review Waiting for reviews feature: ldap papercut Annoying recurring issue with possibly simple fix. labels Aug 23, 2018
@blizzz blizzz added this to the Nextcloud 14 milestone Aug 23, 2018
@blizzz blizzz force-pushed the fix/noid/emptydefaultprefix branch from e166b97 to df57e78 Compare August 23, 2018 13:17
@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 23, 2018
@blizzz
Copy link
Member Author

blizzz commented Aug 23, 2018

found another misbehaviour that should be fixed at the same place, stay tuned

@blizzz
[LDAP] The WebUI Wizard also should not assign empty config IDs
7807add 
With 689df9a the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/noid/emptydefaultprefix branch from df57e78 to 7807add Compare August 23, 2018 15:58
@blizzz blizzz added 3. to review Waiting for reviews backport-request and removed 2. developing Work in progress labels Aug 23, 2018
@blizzz
Copy link
Member Author

blizzz commented Aug 23, 2018

voila

@blizzz blizzz mentioned this pull request Aug 23, 2018
Merged
@rullzer rullzer mentioned this pull request Aug 24, 2018
Closed
3 tasks
rullzer
rullzer approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 🐘

@MorrisJobke MorrisJobke merged commit c850b3a into master Aug 24, 2018
@MorrisJobke MorrisJobke deleted the fix/noid/emptydefaultprefix branch August 24, 2018 19:37
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: ldap papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.

LDAP Wizard: mail and group assoc attribute not saved on auto-detection
3 participants
@blizzz @rullzer @MorrisJobke