Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very first LDAP config has empty ID #3270

Closed
MorrisJobke opened this issue Jan 26, 2017 · 1 comment
Closed

Very first LDAP config has empty ID #3270

MorrisJobke opened this issue Jan 26, 2017 · 1 comment
Assignees
@blizzz
Labels
bug feature: ldap
Milestone
Nextcloud 12.0

Comments

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 26, 2017 •
edited
Loading

The first created LDAP config has the ID `` (empty string). That makes it hard to use the OCS API in #3162 to manipulate this, because then the response is:

$ curl -X GET http://admin:admin@localhost/server/ocs/v2.php/apps/user_ldap/api/v1/config/ -H  "OCS-APIRequest: true" -i
<?xml version="1.0"?>
<ocs>
 <meta>
  <status>failure</status>
  <statuscode>404</statuscode>
  <message>Invalid query, please check the syntax. API specifications are here: http://www.freedesktop.org/wiki/Specifications/open-collaboration-services. DEBUG OUTPUT:
</message>
 </meta>
 <data/>
</ocs>

@blizzz Any idea how to prevent this and fix it?
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Jan 26, 2017
@blizzz
Copy link
Member

blizzz commented Jan 30, 2017

Used to be intentional, but changed with 689df9a in #3162, coming to 12 and 11.0.2.

Workaround until: create 2 and delete the one without prefix subsequently.

@blizzz blizzz closed this as completed Jan 30, 2017
@nextcloud-bot nextcloud-bot mentioned this issue Jun 29, 2018
Closed
blizzz added a commit that referenced this issue Aug 23, 2018
@blizzz
[LDAP] The WebUI Wizard also should not assign empty config IDs
e166b97 
With 689df9a the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz mentioned this issue Aug 23, 2018
Merged
blizzz added a commit that referenced this issue Aug 23, 2018
@blizzz
[LDAP] The WebUI Wizard also should not assign empty config IDs
df57e78 
With 689df9a the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz added a commit that referenced this issue Aug 23, 2018
@blizzz
[LDAP] The WebUI Wizard also should not assign empty config IDs
7807add 
With 689df9a the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz added a commit that referenced this issue Aug 23, 2018
@blizzz
[LDAP] The WebUI Wizard also should not assign empty config IDs
7c33395 
With 689df9a the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blizzz blizzz

Labels
bug feature: ldap
Projects
None yet
Milestone
Nextcloud 12.0
Development

No branches or pull requests
2 participants
@MorrisJobke @blizzz