Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.1.3.1a/11.1 On the page, there are two "h1" headings, where only the "Documents" heading makes sense for structuring content. It is recommended to remove the "All files" heading. #42275

Closed
szaimen opened this issue Dec 14, 2023 · 9 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap accessibility

Comments

@szaimen
Copy link
Contributor

szaimen commented Dec 14, 2023

https://report.bitvtest.de/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-be75bbae42-v11-n1

9.1.3.1a/11.1 On the page, there are two "h1" headings, where only the "Documents" heading makes sense for structuring content. It is recommended to remove the "All files" heading.

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 15, 2023
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jan 2, 2024
@JuliaKirschenheuter
Copy link
Contributor

Dear @michaelnissenbaum,

i would like to clarify this issue with you. Some time ago we have structured our headings based on the section in a left sidebar (navigation), please have a look #36914. This logic is remaining through all our apps and pages.

Screenshot from 2024-01-12 11-02-49

Should we follow another approach?

Thank you!

@michaelnissenbaum
Copy link

In this case, you can follow the same approach. "All files" should be marked as "h1," and "Documents" should be marked as "h2." It's important to note that we should not have two "h1" headings on the page.

@JuliaKirschenheuter
Copy link
Contributor

Thank you @michaelnissenbaum!

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 12, 2024

Dear @michaelnissenbaum,

i've checked this part and "Documents" this is only a heading inside of the document which can be edited and is located inside of Text app. Whole content of the document is controlled by toolbar panel and there could be even several <h1> elements because user wanted to design a markdown document like this:

Screenshot from 2024-01-12 13-38-08

...or user can desing a document like: <h4> -> <h1> -> <h5> -> <h2> -> this is unfortunately out of our control:

Screenshot from 2024-01-12 13-52-38

Besides this a page itself has "all files" heading which comes from a left sidebar:

Screenshot from 2024-01-12 13-45-08

I don't know how to solve this problem. Text app is only the one place where we have a such situation.

@michaelnissenbaum
Copy link

@JuliaKirschenheuter The text within the editor should not be a problem since it is the responsibility of the creator.

@JuliaKirschenheuter
Copy link
Contributor

Thank you @michaelnissenbaum!

Can i then close this issue?

@michaelnissenbaum
Copy link

yes you can.

@JuliaKirschenheuter
Copy link
Contributor

#42275 (comment)

@szaimen
Copy link
Contributor Author

szaimen commented Jan 19, 2024

Chanted to close as not planned since we don't need to fix it

@szaimen szaimen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap accessibility
Projects
None yet
Development

No branches or pull requests

4 participants