Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.1.3.1a/3.1 Although the page has some headings, these only partially help to structure the page content as the page has two "h1" headings, and directly following the second "h1" is an "h5" heading. Ideally, a page should have only one "h1" heading; multiple "h1" headings are only allowed when there are multiple main topics on the page. #42269

Closed
szaimen opened this issue Dec 14, 2023 · 7 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@szaimen
Copy link
Contributor

szaimen commented Dec 14, 2023

9.1.3.1a/3.1 Although the page has some headings, these only partially help to structure the page content as the page has two "h1" headings, and directly following the second "h1" is an "h5" heading. Ideally, a page should have only one "h1" heading; multiple "h1" headings are only allowed when there are multiple main topics on the page.

image

@JuliaKirschenheuter
Copy link
Contributor

@ShGKme could this one be related https://github.com/nextcloud/andy/issues/5?

@ShGKme
Copy link
Contributor

ShGKme commented Dec 14, 2023

@ShGKme could this one be related nextcloud/andy#5?

No. Any number of H* elements in any order is valid in an HTML document.

image

@emoral435
Copy link
Contributor

@JuliaKirschenheuter should we close this issue, then ?

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter should we close this issue, then ?

No, the issue is still there. It is a valid HTML, yes, but it is still not ok that we have h1 -> h3, h1 -> h5, h2 -> h5, and so on. We have to make sure that every page we have have a clear heading structure h1 -> h2, h2 -> h3, h3 -> h4. More about https://www.w3.org/WAI/tutorials/page-structure/headings/

@emoral435 emoral435 self-assigned this Dec 28, 2023
@emoral435 emoral435 added the 1. to develop Accepted and waiting to be taken care of label Dec 28, 2023
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 2, 2024

We are working on this issue through different pages. I have a question regarding this one page with a Text app. There are 2 kind of headings: 1. "All files -> (name of the file)", 2. Content of the text file with all possible variations: h1 -> h6, checkboxes ... The content depends only on the user input, so we can't prevent several <h1> or illogical heading sequence.

The question is: should we remove the first part with file name if the file is on editing mode? I guess this info is important for the user to understand where he actually located.

Screenshot from 2024-01-02 10-21-28

@JuliaKirschenheuter
Copy link
Contributor

#42269 (comment) -> will be handled here #42275 (comment)

@szaimen
Copy link
Contributor Author

szaimen commented Jan 19, 2024

I chanted it to be closed as not planned since it is valid html

@szaimen szaimen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
Development

No branches or pull requests

4 participants