Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework duplicate entry handling for tags #4840

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Rework duplicate entry handling for tags #4840

merged 1 commit into from
Apr 8, 2021

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 27, 2021 •
edited
Loading

Fixes #4833, #4825

@miaulalala miaulalala added this to the v1.10.0 milestone Mar 27, 2021
@miaulalala miaulalala self-assigned this Mar 27, 2021
ChristophWurst
ChristophWurst reviewed Mar 29, 2021
View reviewed changes
@miaulalala miaulalala marked this pull request as ready for review March 30, 2021 15:00
@kesselb

This comment has been minimized.

Sign in to view
kesselb
kesselb previously requested changes Mar 30, 2021
View reviewed changes
st3iny
st3iny reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor code style issues 🤓

@miaulalala

This comment has been minimized.

Sign in to view
@miaulalala miaulalala marked this pull request as draft March 31, 2021 07:31
@ChristophWurst

This comment has been minimized.

Sign in to view
ChristophWurst
ChristophWurst reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

@miaulalala miaulalala force-pushed the enhancement/rework-duplicate-entries-for-tag-message branch from f55925c to 0902d2e Compare March 31, 2021 16:28
@miaulalala
Rework duplicate entry handling for tags
4913892 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enhancement/rework-duplicate-entries-for-tag-message branch from 0902d2e to 4913892 Compare March 31, 2021 16:32
@miaulalala miaulalala marked this pull request as ready for review March 31, 2021 16:32
@miaulalala miaulalala linked an issue Apr 1, 2021 that may be closed by this pull request
Delete all message_tags entries if a user deletes the associated tag #4825
Closed
StCyr
StCyr approved these changes Apr 4, 2021
View reviewed changes
Copy link
Collaborator

@StCyr StCyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does solve #4827 indeed. Thanks 🥳

@StCyr StCyr linked an issue Apr 4, 2021 that may be closed by this pull request
1071 Specified key was too long; max key length is 3072 bytes #4827
Closed
@StCyr StCyr mentioned this pull request Apr 4, 2021
Closed
@miaulalala miaulalala merged commit 68cbd65 into master Apr 8, 2021
@miaulalala miaulalala deleted the enhancement/rework-duplicate-entries-for-tag-message branch April 8, 2021 09:07
@ChristophWurst ChristophWurst mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@st3iny st3iny st3iny left review comments

@kesselb kesselb kesselb left review comments

@StCyr StCyr StCyr approved these changes

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@miaulalala miaulalala

Labels
4. to release enhancement
Projects
None yet
Milestone
v1.10.0
5 participants
@miaulalala @kesselb @ChristophWurst @st3iny @StCyr