Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework how duplicate entries in message_tags are handled #4833

Closed
5 tasks done
miaulalala opened this issue Mar 26, 2021 · 0 comments · Fixed by #4840
Closed
5 tasks done

Rework how duplicate entries in message_tags are handled #4833

miaulalala opened this issue Mar 26, 2021 · 0 comments · Fixed by #4840
Assignees
@miaulalala
Labels
2. developing enhancement
Milestone
v1.10.0

Comments

@miaulalala
Copy link
Contributor

miaulalala commented Mar 26, 2021 •
edited
Loading

Summary

  • Remove the unique index constraint from message_tags. The current implementation doesn't work for a few different reasons and has caused a need for some hacky solutions like Catch duplicate inserts of tags #4821.
  • Add a cleanup job for duplicate entries
  • Add a cleanup job for orphans.
  • The join query in getAllTagsForMessages() needs to handle selecting unique values only.
  • Additionally, to speed up the join query, a shortened index like seen in nextcloud/server#26070 could prove useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miaulalala miaulalala

Labels
2. developing enhancement
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Rework duplicate entry handling for tags nextcloud/mail
1 participant
@miaulalala