Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump php-dependencies #1159

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Bump php-dependencies #1159

merged 2 commits into from
Apr 7, 2022

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Apr 5, 2022 •
edited
Loading

Taking this out of #1149 to get the php8 tests running. Also closes #1145

@jotoeri jotoeri added the dependencies Pull requests that update a dependency file label Apr 5, 2022
@jotoeri jotoeri added this to the 3.0 milestone Apr 5, 2022
@jotoeri jotoeri linked an issue Apr 5, 2022 that may be closed by this pull request
thephpleague/csv does not support PHP 8 #1145
Closed
@jotoeri jotoeri added the 2. developing Work in progress label Apr 5, 2022
@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 5, 2022
@jotoeri jotoeri requested a review from skjnldsv April 5, 2022 18:06
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #1159 (3b1725b) into master (77fb093) will increase coverage by 2.71%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1159      +/-   ##
============================================
+ Coverage     26.43%   29.14%   +2.71%     
+ Complexity      360      356       -4     
============================================
  Files            34       34              
  Lines          1589     1393     -196     
============================================
- Hits            420      406      -14     
+ Misses         1169      987     -182

@jotoeri jotoeri mentioned this pull request Apr 5, 2022
Merged
@jotoeri jotoeri added 2. developing Work in progress 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 2. developing Work in progress labels Apr 5, 2022
@jotoeri
Copy link
Member Author

jotoeri commented Apr 5, 2022

All green now! 🎉
And even coverage is happy for nothing... 😆

@jotoeri jotoeri mentioned this pull request Apr 5, 2022
Merged
@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 5, 2022
@jotoeri

This comment was marked as outdated.

Sign in to view
skjnldsv
skjnldsv previously requested changes Apr 6, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked

@jotoeri
Bump php-dependencies
cdaf802 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri force-pushed the enh/update_php branch 3 times, most recently from cab6d84 to 308c527 Compare April 6, 2022 20:25
@jotoeri
Scope cs-fixer
3b1725b 
Taken from nextcloud/twofactor_webauthn#132

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Member Author

jotoeri commented Apr 6, 2022 •
edited
Loading

So - got it working.
The problem is different symfony versions on server and php-cs-fixer. Similar to nextcloud/twofactor_webauthn#132 i scoped the cs-fixer dependency now. The only drawback currently is, that we have to run composer install twice on a new machine to make the cs-fixer work (first to install the bin-dep, second to then install the deps within the bins, see also bamarni/composer-bin-plugin#72).

@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 6, 2022
@skjnldsv skjnldsv merged commit 5a684a5 into master Apr 7, 2022
@skjnldsv skjnldsv deleted the enh/update_php branch April 7, 2022 09:59
@jotoeri jotoeri modified the milestones: 3.0, 2.5 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

thephpleague/csv does not support PHP 8
2 participants
@jotoeri @skjnldsv