Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to NC-Internal Db-Types #1149

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Move to NC-Internal Db-Types #1149

merged 2 commits into from
Apr 5, 2022

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Mar 29, 2022 •
edited
Loading

Fixes #737 and thus #818 :)

@jotoeri jotoeri added integration Compatibility with other apps/systems 3. to review Waiting for reviews labels Mar 29, 2022
@jotoeri jotoeri added this to the 3.0 milestone Mar 29, 2022
@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 2, 2022
@codecov

This comment was marked as off-topic.

Sign in to view
@jotoeri jotoeri force-pushed the fix/nc_db_types branch 5 times, most recently from 53d40c3 to 265ab78 Compare April 2, 2022 13:16
@jotoeri
Copy link
Member Author

jotoeri commented Apr 2, 2022

Now also added the String-Length fix here. 🙃 - Fix #1152

@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 2, 2022
@jotoeri jotoeri requested a review from nickvergessen April 2, 2022 13:22
This was linked to issues Apr 2, 2022
New DB-Limit on String Length #1152
Closed
Minversion 21 - Todo #818
Closed
@jotoeri jotoeri requested a review from nickvergessen April 4, 2022 11:12
nickvergessen
nickvergessen reviewed Apr 4, 2022
View reviewed changes
appinfo/info.xml Outdated Show resolved Hide resolved
@jotoeri jotoeri mentioned this pull request Apr 5, 2022
Merged
jotoeri added 2 commits April 5, 2022 10:27
@jotoeri
Move to NC-Internal Db-Types
7417ce5 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Migrate long text columns
056692f 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri merged commit 2e5cf3f into master Apr 5, 2022
@jotoeri jotoeri deleted the fix/nc_db_types branch April 5, 2022 17:19
@jotoeri
Copy link
Member Author

jotoeri commented Apr 5, 2022

Fixing php8 separately.

@jotoeri jotoeri mentioned this pull request Apr 5, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 8, 2022
Closed
8 tasks
@jotoeri jotoeri modified the milestones: 3.0, 2.5 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews integration Compatibility with other apps/systems
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

New DB-Limit on String Length Minversion 21 - Todo Minversion 21 - Move to NC internal db column Types
3 participants
@jotoeri @nickvergessen @skjnldsv