Big sur icon annotations

[elsiehupp]

This is a redux of #4714 because of issues identified in #5757.

@claucambra—could you elaborate on the how the previous version of this broke the app icon, so I can fix it? Thanks!

[elsiehupp]

(I wasn't sure how to reopen a merged pull request, so I may have done this incorrectly.)

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5793-7580ba86a00a70ef7ff6b8fa56d3278c5c4df9a6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[codecov]

Codecov Report

Attention: Patch coverage is 48.19897% with 302 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (ec7fd95) to head (7580ba8).
Report is 3681 commits behind head on master.

Files with missing lines	Patch %	Lines
src/libsync/clientsideencryption.cpp	44.40%	164 Missing ⚠️
src/libsync/updatefiledropmetadata.cpp	58.77%	47 Missing ⚠️
src/libsync/logger.cpp	35.13%	24 Missing ⚠️
src/libsync/owncloudpropagator.cpp	30.43%	16 Missing ⚠️
src/libsync/theme.cpp	0.00%	9 Missing ⚠️
src/libsync/configfile.cpp	0.00%	8 Missing ⚠️
src/common/syncjournaldb.cpp	55.55%	4 Missing ⚠️
src/libsync/account.cpp	42.85%	4 Missing ⚠️
src/libsync/capabilities.cpp	55.55%	4 Missing ⚠️
src/libsync/encryptfolderjob.cpp	0.00%	3 Missing ⚠️
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5793      +/-   ##
==========================================
+ Coverage   57.83%   60.34%   +2.51%     
==========================================
  Files         141      143       +2     
  Lines       18143    18530     +387     
==========================================
+ Hits        10493    11182     +689     
+ Misses       7650     7348     -302     

Files with missing lines	Coverage Δ
src/common/filesystembase.cpp	76.43% <ø> (ø)
src/common/ownsql.cpp	66.93% <ø> (+0.40%)	⬆️
src/common/ownsql.h	81.25% <ø> (-18.75%)	⬇️
src/common/syncjournaldb.h	75.00% <ø> (ø)
src/csync/csync.h	75.00% <ø> (ø)
src/csync/std/c_time.cpp	76.00% <100.00%> (ø)
src/csync/vio/csync_vio_local_win.cpp	81.39% <ø> (ø)
src/libsync/account.h	40.00% <ø> (+3.15%)	⬆️
src/libsync/bulkpropagatorjob.cpp	74.71% <ø> (+1.53%)	⬆️
src/libsync/bulkpropagatorjob.h	50.00% <ø> (ø)
... and 40 more

... and 17 files with indirect coverage changes

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[claucambra]

Hello @elsiehupp sorry for the late reply

We had a major issue as after the icon generation in the initial build step (using inkscape), we would just get a completely black icon for the app; we didn't have this issue without the annotations. Are you able to reproduce this?

[elsiehupp]

Hello @elsiehupp sorry for the late reply

We had a major issue as after the icon generation in the initial build step (using inkscape), we would just get a completely black icon for the app; we didn't have this issue without the annotations. Are you able to reproduce this?

No worries about the late reply (I say like three months later lol)

What are the steps for running the Inkscape build? Last I checked the CI build process wasn't included in the main repository, so unless I'm missing something, could you point me in the direction of where to look? (Also last I checked the local build process was broken on macOS, so I wouldn't even know where to start at this point.)

[Rello]

Hello,

Thank you for your contribution to the Desktop Client with this pull request.
We are closing this request as it is outdated, no longer relevant (e.g., due to Qt 6), or does not align with the current roadmap.

We truly value your support and hope to see more contributions from you in the future!

Best regards,
Nextcloud Desktop Team