Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS icon #5757

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix macOS icon #5757

merged 1 commit into from
Jun 2, 2023

Conversation

claucambra
Copy link
Collaborator

This reverts commit 04d16b7 as unfortunately this breaks the app icon

@claucambra claucambra self-assigned this Jun 2, 2023
@claucambra claucambra force-pushed the work/fix-mac-icon branch from 0245828 to ab2a177 Compare June 2, 2023 07:00
@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #5757 (77c419c) into master (28c0518) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5757   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files         143      143           
  Lines       18518    18518           
=======================================
+ Hits        11178    11179    +1     
+ Misses       7340     7339    -1     

see 1 file with indirect coverage changes

This reverts commit 04d16b7.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the work/fix-mac-icon branch from ab2a177 to 77c419c Compare June 2, 2023 10:58
@mgallien mgallien enabled auto-merge June 2, 2023 10:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5757-77c419c554975d857fbb3ee694a2933b60397370-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants