Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] fix: Pass user id along to properly check permissions in background jobs #5595

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 14, 2024

Backport of #4485

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

cypress bot commented Feb 14, 2024

Passing run #1789 ↗︎

0 6 0 0 Flakiness 0

Details:

Merge aeb6917 into 5801565...
Project: Deck Commit: ac2234e4aa ℹ️
Status: Passed Duration: 02:08 💡
Started: Feb 14, 2024 11:18 AM Ended: Feb 14, 2024 11:20 AM

Review all test suite changes for PR #5595 ↗︎

@juliusknorr juliusknorr marked this pull request as ready for review February 14, 2024 11:26
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 79472 was 68024 (+16.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@juliusknorr juliusknorr merged commit 3ff9248 into stable25 Feb 14, 2024
25 checks passed
@nickvergessen nickvergessen deleted the backport/4485/stable25 branch February 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant