deck breaks sharing of directories in 25.0.13.6 #5576
Comments
|
just to clarify: the issue occurred after the latest update for nc 25.0.13.5 -> 25.0.13.6 |
|
Same issue with me. Opened issue a while ago, still no reply on this:#5535 At the moment I have to choose between Deck or File sharing for my company. We rely on Deck for project management, but we share a lot externally to clients, so this is a pretty bad bug. Seems like Deck is calling some group permissions and impacting link sharing. Link share for whatever reason checks for group permissions and then either breaks the link, or when a user goes to click on "Download" on the link page, they get an error. However I am on nextcloud 25.0.13.2. I believe it was the 1.8.7 update that broke. Don't know if this is just a Nextcloud 25 incompatibility issue. Does anyone know if upgrading to Nextcloud 26 solves this? |
|
If it can be of use to anyone, the only way I was able to fix my issue was downgrading to Deck 1.8.5.
I tested my link shares and the Deck app and both of them are now functioning correctly. If you have a cron job to auto-update apps and what not, ensure to disable that. |
|
I backported fix to #5595 Testing is very welcome :) |
|
Thank you @juliushaertl |
|
good morning @juliushaertl I just updated the deck app to 1.8.8 and re-enabled it a short look into tested a public share link - looks like all thinks are fine again thank you for the fix |
How to use GitHub
Describe the bug
After the latest update to NC 25.0.13.6 (25.0.13 Enterprise), existing and new shares via links are broken and not accessible anymore.
Esp. while "downloading" the files from a share via link, the error is displayed:
or
As I inspected the error shown below from the log file, I have disable the App Deck Version 1.8.7, and all things work ok again.
If you open the share link in a browser where you have a regular authenticated nc session open, the download works.
Example share dumped in json:
{ "id": "32545", "file_id": 4422961, "owner": "D3FC4A3A-29CD-4DF8-8A26-EE91D2891061", "initiator": "D3FC4A3A-29CD-4DF8-8A26-EE91D2891061", "time": "2024-02-07T09:37:41+00:00", "permissions": 31, "path": "\/test\/testshare", "name": "testshare", "is_directory": true, "type": "link", "token": "esCLHiWZ73epwFb" }error:
The behavior is independent of the client in use, it is a server issue.
Operating system:
Web server:
apache2 2.4.56-1~deb11u2 amd64
Database:
mariadb-server 1:10.5.21-0+deb11u1
PHP version:
Nextcloud version: (see Nextcloud admin page)
List of activated apps:
Nextcloud configuration:
Nextcloud log (data/nextcloud.log)
{ "app" : "index", "exception" : { "Code" : 0, "CustomMessage" : "--", "Exception" : "Exception", "File" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/AppFramework/Http/Dispatcher.php", "Line" : 165, "Message" : "Argument 2 passed to OCA\\Deck\\Service\\CirclesService::isUserInCircle() must be of the type string, null given, called in /var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/PermissionService.php on line 234 in file '/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/CirclesService.php' line 70", "Previous" : { "Code" : 0, "Exception" : "TypeError", "File" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/CirclesService.php", "Line" : 70, "Message" : "Argument 2 passed to OCA\\Deck\\Service\\CirclesService::isUserInCircle() must be of the type string, null given, called in /var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/PermissionService.php on line 234", "Trace" : [ { "class" : "OCA\\Deck\\Service\\CirclesService", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/PermissionService.php", "function" : "isUserInCircle", "line" : 234, "type" : "->" }, { "class" : "OCA\\Deck\\Service\\PermissionService", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/PermissionService.php", "function" : "userCan", "line" : 114, "type" : "->" }, { "class" : "OCA\\Deck\\Service\\PermissionService", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/PermissionService.php", "function" : "getPermissions", "line" : 164, "type" : "->" }, { "class" : "OCA\\Deck\\Service\\PermissionService", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Sharing/DeckShareProvider.php", "function" : "checkPermission", "line" : 289, "type" : "->" }, { "class" : "OCA\\Deck\\Sharing\\DeckShareProvider", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Sharing/DeckShareProvider.php", "function" : "applyBoardPermission", "line" : 668, "type" : "->" }, { "class" : "OCA\\Deck\\Sharing\\DeckShareProvider", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Sharing/DeckShareProvider.php", "function" : "resolveSharesForRecipient", "line" : 780, "type" : "->" }, { "class" : "OCA\\Deck\\Sharing\\DeckShareProvider", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Share20/Manager.php", "function" : "getSharedWith", "line" : 1407, "type" : "->" }, { "class" : "OC\\Share20\\Manager", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/files_sharing/lib/MountProvider.php", "function" : "getSharedWith", "line" : 99, "type" : "->" }, { "class" : "OCA\\Files_Sharing\\MountProvider", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Files/Config/MountProviderCollection.php", "function" : "getMountsForUser", "line" : 134, "type" : "->" }, { "class" : "OC\\Files\\Config\\MountProviderCollection", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Files/SetupManager.php", "function" : "addMountForUser", "line" : 226, "type" : "->" }, { "args" : [ "*** sensitive parameters replaced ***" ], "class" : "OC\\Files\\SetupManager", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Files/SetupManager.php", "function" : "OC\\Files\\{closure}", "line" : 318, "type" : "->" }, { "class" : "OC\\Files\\SetupManager", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Files/SetupManager.php", "function" : "setupForUserWith", "line" : 227, "type" : "->" }, { "class" : "OC\\Files\\SetupManager", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/legacy/OC_Util.php", "function" : "setupForUser", "line" : 111, "type" : "->" }, { "class" : "OC_Util", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/apps/files_sharing/lib/Controller/ShareController.php", "function" : "setupFS", "line" : 673, "type" : "::" }, { "class" : "OCA\\Files_Sharing\\Controller\\ShareController", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/AppFramework/Http/Dispatcher.php", "function" : "downloadShare", "line" : 225, "type" : "->" }, { "class" : "OC\\AppFramework\\Http\\Dispatcher", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/AppFramework/Http/Dispatcher.php", "function" : "executeController", "line" : 133, "type" : "->" }, { "class" : "OC\\AppFramework\\Http\\Dispatcher", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/AppFramework/App.php", "function" : "dispatch", "line" : 172, "type" : "->" }, { "class" : "OC\\AppFramework\\App", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Route/Router.php", "function" : "main", "line" : 298, "type" : "::" }, { "class" : "OC\\Route\\Router", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/base.php", "function" : "match", "line" : 1053, "type" : "->" }, { "class" : "OC", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/index.php", "function" : "handleRequest", "line" : 36, "type" : "::" } ] }, "Trace" : [ { "class" : "OC\\AppFramework\\Http\\Dispatcher", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/AppFramework/App.php", "function" : "dispatch", "line" : 172, "type" : "->" }, { "class" : "OC\\AppFramework\\App", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/private/Route/Router.php", "function" : "main", "line" : 298, "type" : "::" }, { "class" : "OC\\Route\\Router", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/lib/base.php", "function" : "match", "line" : 1053, "type" : "->" }, { "class" : "OC", "file" : "/var/www/nextcloud/nextcloud-25.0.13.6/index.php", "function" : "handleRequest", "line" : 36, "type" : "::" } ] }, "level" : 3, "message" : "Argument 2 passed to OCA\\Deck\\Service\\CirclesService::isUserInCircle() must be of the type string, null given, called in /var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/PermissionService.php on line 234 in file '/var/www/nextcloud/nextcloud-25.0.13.6/apps/deck/lib/Service/CirclesService.php' line 70", "method" : "GET", "remoteAddr" : "...", "reqId" : "6NBM02YqjuDE6Jck4BdB", "time" : "2024-02-07T09:35:58+00:00", "url" : "/s/k98TFE6SF2faSMS/download/FILENAME", "user" : "--", "userAgent" : "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0", "version" : "25.0.13.6" }The text was updated successfully, but these errors were encountered: