-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchcors scrolling #1150
Fix anchcors scrolling #1150
Conversation
2889952
to
bda1252
Compare
bda1252
to
1dcd676
Compare
Currently only the session editor ( |
1dcd676
to
c45360f
Compare
@mejo- I've updated current PR, and opened one more to nextcloud-vue. Please review one more time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @Koc, great to hear that onLoaded
works now 😊
Regarding your PR against nextcloud-vue, I think that we should rather change the behaviour here in Collectives. It's not given that the contents given to NcAppContent
contain a heading like in collectives. Adding something like the following to Collectives.vue
should do the trick:
:deep(.splitpanes__pane-details) {
scroll-padding-top: 60px;
scroll-behavior: smooth;
}
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
c45360f
to
0847e80
Compare
@mejo- thank you for suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Summary
Steps to reproduce:
Expected result:
Actual result:
🖼️ Screenshots
🚧 TODO
onLoaded
callback is not called in my case, so I'm usingsetTimeout
. Any idea how to fix that?Merge Fix scroll to elements with sticky header nextcloud-libraries/nextcloud-vue#5435🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)