-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading anchors point to #undefined
in view mode
#1114
Comments
not reproducible for me in current main branch after running |
I have the same problem. Only in view mode anchor points to #undefined. In edit mode the anchor points to the correct position. Collectives app version: 2.10.0 |
FindingsI looked into this issue, couldn't quite figure it out but still possibly made some findings. the links rendering as undefined most likely has something to do with the lifecycle hooks not beeing called in the way they are ment to be. Somehow the setupReader and setupEditor functions in collectives that start those editors make it so the reader and editor influence one another. Inspecting the stack trace with breakpoints it was visible that addNode in nodes/Heading/index.js was called before the onCreated Hook which could possibly cause issues. Another possibility would be that the influence of different orders of setContent-calls in collectives affects the link-values, which would bring up the question why setContent calls don't all trigger the same update cycle. I don't know if any of that will be helpful but I did my best. |
This finally got fixed in Text with nextcloud/text#5893. |
Describe the bug
Heading anchors point to
#undefined
in view mode.To Reproduce
Steps to reproduce the behavior:
#
symbol left to a heading and see the URL.Server details:
The text was updated successfully, but these errors were encountered: