Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix calendar handling on android #3475

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 15, 2021

Fix #3394
Inspired by nextcloud/server#28767

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing
docker run -d \
-e CALENDAR_BRANCH=enh/3394/fix-moving-calendars \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.178.34 \
--name nextcloud-easy-test \
--user=www-data \
ghcr.io/szaimen/nextcloud-easy-test:latest

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added the 2. developing Work in progress label Sep 15, 2021
@szaimen szaimen added this to the v2.4.0 milestone Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #3475 (83a7bf5) into master (c5bf7da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3475   +/-   ##
=========================================
  Coverage     28.49%   28.49%           
  Complexity      123      123           
=========================================
  Files           163      163           
  Lines          5847     5847           
  Branches        856      856           
=========================================
  Hits           1666     1666           
  Misses         4181     4181           
Flag Coverage Δ
javascript 23.03% <ø> (ø)
php 94.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/AppNavigation/CalendarList.vue 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bf7da...83a7bf5. Read the comment docs.

@szaimen szaimen changed the title fix moving calendars on android fix calendar handling on android Sep 15, 2021
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 15, 2021
@szaimen szaimen marked this pull request as ready for review September 15, 2021 09:13
@szaimen szaimen added the bug label Sep 15, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Sep 15, 2021

/backport to stable2.3

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Sep 15, 2021
Copy link
Member

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it, but the code is reasonable.

@szaimen
Copy link
Contributor Author

szaimen commented Sep 15, 2021

Didn't test it, but the code is reasonable.

I've tested it and it works :)

@szaimen szaimen merged commit 69ef435 into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/3394/fix-moving-calendars branch September 15, 2021 09:35
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot activate or deactivate calendars in default Android browser
2 participants