Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Yamllint Github Action #286

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Fix broken Yamllint Github Action #286

merged 3 commits into from
Jun 23, 2023

Conversation

staticdev
Copy link
Collaborator

@staticdev staticdev commented Jun 19, 2023 •
edited
Loading

Closes #284

This PR introduces following changes:

  • Replaces broken yamlint GA with yamllint installation and execution steps
  • Merges both yamllint and ansible-lint workflows for easier maintenance of linting

@staticdev staticdev added the ci Continuous Integration label Jun 19, 2023
@staticdev staticdev force-pushed the bugfix/remove-yamllint-ga branch 4 times, most recently from 27cdf5a to de3a9da Compare June 19, 2023 16:54
@staticdev staticdev requested review from aalaesar and wiktor2200 June 19, 2023 16:56
@staticdev
Fix broken Yamllint Github Action
eb16162 
Signed-off-by: staticdev <staticdev-support@proton.me>
@staticdev staticdev force-pushed the bugfix/remove-yamllint-ga branch from de3a9da to eb16162 Compare June 19, 2023 17:01
@staticdev
Fix contacts version to pass latest NC
b4babe1 
Signed-off-by: staticdev <staticdev-support@proton.me>
@staticdev staticdev force-pushed the bugfix/remove-yamllint-ga branch from 7d98f88 to b4babe1 Compare June 19, 2023 17:33
@staticdev
Copy link
Collaborator Author

staticdev commented Jun 22, 2023 •
edited
Loading

@aalaesar @wiktor2200 I would like to merge this PR since lint part is working. Other errors are because of NC27 installation, it seems that now OCC changes/removed some argument we use on php occ maintenance:install.

Then I will follow up the work on #285

@wiktor2200
Copy link
Collaborator

Hi @staticdev. Sorry for quite a long time, no response from my side.
Thanks a lot for keeping it up-to-date and actively maintained, I appreciate that :)
I've left small comment in code. But approving anyways if you agree with my comment just apply suggestion if not feel free to merge it as it is :)

wiktor2200
wiktor2200 previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@wiktor2200 wiktor2200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left small comment, but I think it's optional and can be changed later. Up-to you @staticdev :)

@staticdev @wiktor2200
Update .github/workflows/lint.yml
ce7e126 
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>
Signed-off-by: staticdev <staticdev-support@proton.me>
@staticdev staticdev requested a review from wiktor2200 June 23, 2023 07:41
@staticdev
Copy link
Collaborator Author

I've left small comment, but I think it's optional and can be changed later. Up-to you @staticdev :)

Thanks @wiktor2200, I added your change, now I need approval again XD

@wiktor2200 wiktor2200 merged commit 7149b26 into main Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/remove-yamllint-ga branch June 23, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktor2200 wiktor2200 wiktor2200 approved these changes

@aalaesar aalaesar Awaiting requested review from aalaesar

Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yamllint GA abandoned not working since last year
2 participants
@staticdev @wiktor2200