Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yamllint GA abandoned not working since last year #284

Closed
staticdev opened this issue Jun 17, 2023 · 3 comments · Fixed by #286
Closed

yamllint GA abandoned not working since last year #284

staticdev opened this issue Jun 17, 2023 · 3 comments · Fixed by #286
Labels
ci Continuous Integration

Comments

@staticdev
Copy link
Collaborator

staticdev commented Jun 17, 2023 •
edited
Loading

The pipeline is failing every execution. I suggest we create replace the action and have single lint workflow with yamllint and ansible-lint as in:

https://github.com/staticdev/ansible-role-signal/blob/main/.github/workflows/tests.yml#LL16C1-L37C23
@staticdev staticdev changed the title yamllint GA abandoned since last year yamllint GA abandoned not working since last year Jun 17, 2023
@aalaesar
Copy link
Member

Hello there !

The pipeline is failing every execution.

can you elaborate ? A quick check shows everything looks ok .

I suggest we create replace the action and have single lint workflow with yamllint and ansible-lint

OK as ansible lint test comes already with ansible-lint For what I'm seeing.

regards

@staticdev
Copy link
Collaborator Author

staticdev commented Jun 17, 2023 •
edited
Loading

@aalaesar just check here https://github.com/nextcloud/ansible-collection-nextcloud-admin/actions

Also on our readme it says it is failing.

@staticdev staticdev mentioned this issue Jun 19, 2023
Merged
@staticdev staticdev added the ci Continuous Integration label Jun 22, 2023
@wiktor2200
Copy link
Collaborator

Hi! Sorry for late response. Yeah it's a good idea to fix that. I've already reviewed these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken Yamllint Github Action nextcloud/ansible-collection-nextcloud-admin
3 participants
@staticdev @aalaesar @wiktor2200