-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locked AD/LDAP Accounts / APP CRASH ON RELOGIN #8302
Comments
I have cloned the master (3.17.x) and now the app crashes on relogin with the following exception in logcat:
|
We did not changed anything in web login flow, as far as I remember. Is this happening only in regard with LDAP? |
when login fails, login fails, and it does not matter why it fails. no change there.
You need to login first and grant permission, right. Did you have to do that or was it locked straight away? |
In latest master 3.17. the accounts are not locked anymore but the app crashes with an exception above... |
For the second behavoir (app crash) it comes from here i think: In class com.owncloud.android.lib.common.OwnCloudClientFactory
on line: String password = am.peekAuthToken(account, AccountTypeUtils.getAuthTokenTypePass(account.type)); when this line fails password would become null i think and then the exception is raised on the return call, in Credentials.basic(username, password)... Maybe in older libs am.peekAuthToken returns an empty string and not null so then the credentials are build wrong and the account will get locked... |
Check the AD logs, they'll tell you who was locked why. |
As i said i used the same credentials and this happens with all other AD-Users too. Sorry i forgot to write that logins on desktop are fine without issues. I made a test on a fresh Nextclous Server 19 Installation on another Test AD with same results... On Second Login badPassword Counter raises although the credentials were valid. |
If the password is valid, why is AD locking the account anyway? |
the password i entered in the app was correct... but it seems that it is not stored or loaded from account storage correctly. |
@tobiasKaminsky I am interpreting the login flow login and granting access worked on the second time, and the unsuccessful auth happened afterwards. The login name must be correct, otherwise the lock on AD would not happen. So there's something with the new app token. Anyway, I am outta here. |
Yes would agree this. |
any update/news on this? |
The issue(s) occurs when the user grants access to the device on after posting user/pass. |
for Version 3.17.x I could fix the null result for passwort in android-library/src/main/java/com/owncloud/android/lib/common/OwnCloudClientFactory.java by replacing
Could somebody review this change? |
pinging @tobiasKaminsky but won't happen before next week I am afraid. |
I've tested around and noticed that after reboot account was locked again...then i search the whole code for another call of |
Duplicate of #8370 |
Steps to reproduce
Expected behaviour
Actual behaviour
Environment data
Android version: Android 8-11
Device models: Samsung A40, S9, Tab S4,TabS6, TabS3...
Stock or customized system: Stock, with and without MDM (both tested)
Nextcloud app version: Tested Versions: 3.14.x, 3.15.x
Last Good Version: 3.13.x
Nextcloud server version: Tested Versions: 18,19,21
2-Node Cluster behind a loadbalancer
Reverse proxy:
Logs
Web server error log
Error Log shows no related errors
Access Log (IPs changed):
Nextcloud log (data/nextcloud.log)
NOTE: Be super sure to remove sensitive data like passwords, note that everybody can look here! You can use the Issue Template application to prefill some of the required information: https://apps.nextcloud.com/apps/issuetemplate
The text was updated successfully, but these errors were encountered: