Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter specified as non-null is null #8370

Closed
Mr-KayJayDee opened this issue May 8, 2021 · 30 comments · Fixed by nextcloud/android-library#638
Closed

Parameter specified as non-null is null #8370

Mr-KayJayDee opened this issue May 8, 2021 · 30 comments · Fixed by nextcloud/android-library#638

Comments

@Mr-KayJayDee
Copy link

Mr-KayJayDee commented May 8, 2021

************ CAUSE OF ERROR ************

java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter password
	at okhttp3.Credentials.basic(Unknown Source:8)
	at okhttp3.Credentials.basic$default(Credentials.kt:28)
	at okhttp3.Credentials.basic(Unknown Source:2)
	at com.owncloud.android.lib.common.OwnCloudClientFactory.createNextcloudClient(OwnCloudClientFactory.java:217)
	at com.owncloud.android.operations.RefreshFolderOperation.updatePredefinedStatus(RefreshFolderOperation.java:338)
	at com.owncloud.android.operations.RefreshFolderOperation.updateCapabilities(RefreshFolderOperation.java:311)
	at com.owncloud.android.operations.RefreshFolderOperation.updateOCVersion(RefreshFolderOperation.java:277)
	at com.owncloud.android.operations.RefreshFolderOperation.run(RefreshFolderOperation.java:230)
	at com.owncloud.android.lib.common.operations.RemoteOperation.run(RemoteOperation.java:359)
	at java.lang.Thread.run(Thread.java:923)

************ APP INFORMATION ************
ID: com.nextcloud.client
Version: 30160090
Build flavor: gplay

************ DEVICE INFORMATION ************
Brand: OnePlus
Device: OnePlus6
Model: ONEPLUS A6003
Id: RQ2A.210305.006
Product: OnePlus6

************ FIRMWARE ************
SDK: 30
Release: 11
Incremental: 1615660065

@tobiasKaminsky tobiasKaminsky added bug needs info Waiting for info from user(s). Issues with this label will auto-stale. labels May 10, 2021
@tobiasKaminsky
Copy link
Member

Can you tell us when this happens?

@Mr-KayJayDee
Copy link
Author

It happened after I logged in, the app tried to load my files from my server.

@Posedge
Copy link

Posedge commented May 16, 2021

I'm having the same, also on OnePlus (OnePlus 8 Pro in my case). This is the crash report:

************ CAUSE OF ERROR ************

java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter password
at okhttp3.Credentials.basic(Unknown Source:8)
at okhttp3.Credentials.basic$default(Credentials.kt:28)
at okhttp3.Credentials.basic(Unknown Source:2)
at com.owncloud.android.lib.common.OwnCloudClientFactory.createNextcloudClient(OwnCloudClientFactory.java:217)
at com.owncloud.android.operations.RefreshFolderOperation.updatePredefinedStatus(RefreshFolderOperation.java:338)
at com.owncloud.android.operations.RefreshFolderOperation.updateCapabilities(RefreshFolderOperation.java:311)
at com.owncloud.android.operations.RefreshFolderOperation.updateOCVersion(RefreshFolderOperation.java:277)
at com.owncloud.android.operations.RefreshFolderOperation.run(RefreshFolderOperation.java:230)
at com.owncloud.android.lib.common.operations.RemoteOperation.run(RemoteOperation.java:359)
at java.lang.Thread.run(Thread.java:923)

************ APP INFORMATION ************
ID: com.nextcloud.client
Version: 30160090
Build flavor: gplay

************ DEVICE INFORMATION ************
Brand: OnePlus
Device: OnePlus8Pro
Model: IN2023
Id: RP1A.201005.001
Product: OnePlus8Pro_EEA

************ FIRMWARE ************
SDK: 30
Release: 11
Incremental: 2103221755

Let me know if I can post anything else to help debug this.

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented May 19, 2021

Further info: The crash only happens when I have the
"nextcloud05.webo.cloud" account selected. If I quickly change the
account (when the app is loading) to my "us.cloudamo.com" account, the
error does not occur.
When I then visited nextcloud05.webo.cloud manually,
this message showed: "We have detected multiple invalid login attempts
from your IP. Therefore your next login is throttled up to 30 seconds."
Thus, my guess is that my free account at webo.cloud was
either disabled, or hit some other limitation, causing either the
sign-in to be rejected, or the sign-in process to error out part-way. (I
can't confirm if my account is still active atm because manual sign-in
also keeps being rejected, with the message: "Too many requests. There
were too many requests from your network. Retry later or contact your
administrator if this is an error.")
That said, it would be good of the Nextcloud system can gracefully
handle rejected/errored sign in attempts (and present a useful message),
rather than the current error popup.

@Timoses
Copy link

Timoses commented May 20, 2021

I received the crash report as well ([#8437]).
The crash report kept appearing every time I opened the app. I was unable to access Nextcloud via App.

I uninstalled the app and installed it again.

I also see "We have detected multiple invalid login attempts
from your IP. Therefore your next login is throttled up to 30 seconds." now when I want to login through the app.

When I try to login via the reinstalled app, I get until "Grant access". After I press it, the circle right to "Grant access" button appears indicating it is working. However, it never finishes. When I touch the screen wildly, touching "Grant access" button repeatedly it jumps back to the Login screen.

When I login via Browser (firefox) on the mobile I also get the "We have detected multiple invalid login attempts
from your IP. Therefore your next login is throttled up to 30 seconds.". Logging in is successful there.

@Timoses
Copy link

Timoses commented May 20, 2021

I also seem to be getting a "Access Forbidden\nInvalid request" from time to time in the app after trying to log in (before grant access).

@tobiasKaminsky
Copy link
Member

What login name do you use?
Is it a email?

@tobiasKaminsky
Copy link
Member

Can you create us a test account, test if the problem occurs also there and if so send the credentials to tobias at nextcloud dot com with a reference to this issue?

@tobiasKaminsky
Copy link
Member

So I thought it would be connected to brute force.
Therefore I enabled it, had 30s timeout and connected a new installed app.
It works without any problems.

What kind of user backend do you have?
I am really clueless here…

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented May 28, 2021

There is an APK file in PR #8494 (comment), which you can install in parallel to your existing Nextcloud app.

Can someone install it, see if it crashes and also post logcat?

@eiver
Copy link

eiver commented Jul 26, 2021

I triggered the bug, when I changed my password using the browser on the desktop. The mobile client did not know, that the password was changed and kept trying to login in a loop using an old password. This behavior was considered a brute-force attack by the server. After this the mobile app started crashing with error log just like in the original post.

@szotsaki
Copy link

I can fully reproduce this issue when there is a port specified for the URL (https://xxxxxxx.com:2345) and you're reading the QR code for the app login (which QR code is displayed on this URL).

@maxmeyer
Copy link

maxmeyer commented Jul 31, 2021

I have the same error. I set up a new account in the app. The account is an LDAP account - OpenLDAP.

  1. Enter hostname
  2. Enter Username + Password
  3. Acknowledge login
  4. Stack trace

As mentioned before, removing the circles app worked around the problem for me as well.

I can find this in the logs:

grafik

@bignose-debian
Copy link

removing the circles app worked around the problem for me as well

I tested this by disabling the Circles app on the server. Then attempting to load the NextCloud app (version 3.16.1, the latest in F-Droid) on a mobile device.

The NextCloud mobile app crashed in the same manner. I conclude the the Circles app was not the (only?) cause of this.

@cm-schl
Copy link

cm-schl commented Aug 12, 2021

I'm seeing the same error on one device and also see the some parallels in the behavior described in nextcloud/server#26502 or nextcloud/server#26806 (app passwords seem to get invalid).
Making some tests I changed the LDAP user password and at some point the "app password" of the Nextcloud App seamed to not work anymore. But the app password of the Talk client worked.

I saw that after changing the password and when the token seams to get invalid (you also get dropped out of the web interface) the user got asked one time for the server address like when you're starting the Android app for the first time. If the users does not insert anything, afterwards he only can see the NullPointerException and can't insert a new password until the account gets deleted manually in the phone settings...

@M15S21
Copy link

M15S21 commented Apr 17, 2023

Transaction error

Parameter specified as non-null is null: method trust.blockchain.b lockchain.nano.NanoRpcService $Companion.toBlock, parameter work

1 similar comment
@M15S21
Copy link

M15S21 commented Apr 17, 2023

Transaction error

Parameter specified as non-null is null: method trust.blockchain.b lockchain.nano.NanoRpcService $Companion.toBlock, parameter work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.