Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoupload doesnt work at all... #3296

Closed
RedondoBoony opened this issue Nov 28, 2018 · 33 comments
Closed

Autoupload doesnt work at all... #3296

RedondoBoony opened this issue Nov 28, 2018 · 33 comments
Assignees
Labels
bug feature: auto upload needs info Waiting for info from user(s). Issues with this label will auto-stale. stale

Comments

@RedondoBoony
Copy link

Android App 3.3.2, autoupload doesnt work at all (Galaxy S9+).
I can add it, but nothing happens.
Turned off (only during charging/only Wlan) but no luck...
4.0.4 on server (Synology DS918+)

@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #2630 (Upload not working correctly), #498 (Autoupload doesn't work at all with Nextcloud App Beta 20170101), #1498 (Autoupload skips folders), #1702 (AutoUpload Issues), and #2849 (AutoUpload does not work on all folders).

@voidzero
Copy link

voidzero commented Dec 6, 2018

Whatever the case maybe and whatever old ticket this is related to, the truth is that it is still not working.

You know, it would be ideal if there is a manual auto-upload button too, to make sure that whatever hasn't been uploaded, will still be uploaded, to the right subfolder (e.g. based on year and month). The other thing this would do is to move local images that have been uploaded to the specified fold.r (app folder for instance.)

Having to do this by hand gets a bit tedious, I think. And it really sucks that I only noticed it stopped working right now, with a ton of not properly uploaded images that I do need to take care of by hand now I guess.

@tobiasKaminsky
Copy link
Member

On Samsung you have to exclude our app from battery optimization.
There are two settings as far as I remember.

@Hundsbuah
Copy link

Ich hab ein Note 9 und hab die App aus allen Battery Optimization Einstellungen raus genommen. Auto Upload funktioniert nur wenn ein neues Bild gemacht wird. Das wird sofort hochgeladen. Alle anderen, alten Bilder/Dateien werden nicht hochgeladen....

@AndyScherzinger
Copy link
Member

@Hundsbuah this is expected, see #285 and is on the roadmap to be implemented.

@voidzero
Copy link

@tobiasKaminsky D'Oh! Why did I not think of this. Thank you, I think that this might have done the trick for me.

@tobiasKaminsky
Copy link
Member

@AndyScherzinger we should really include this somehow as a warning/dialog.
Do you have an idea when and how?

Show an dialog after enabling an auto upload folder?
"Your device may have battery optimization. AutoUpload works only properly if you exclude this app from it."

Do we want to limit this to Samsung right now?

@AndyScherzinger
Copy link
Member

yeah we should probably have such a popup and should also make it OEM dependend, Samsung definitely while in case I remember correctly this is also true for Xiaomi and Huawei, right?

@tobiasKaminsky
Copy link
Member

I do not recall, but it could be.

@tobiasKaminsky
Copy link
Member

PR in #3350

@metafarion
Copy link

Not sure about newer models, but the LG G4 running Android 6.0 has the battery optimization exception thing too. Setting an exception for the Nextcloud app didn't appear to make Auto Upload functional, but I couldn't say whether or not it is necessary for Auto Upload to work.

@voidzero
Copy link

Ok, so as it seems, even with the batt optimization disabled, this stuff just does not work properly and I have to upload these ignored files by hand.

@peteman52
Copy link

can confirm, that autoupload doesn't work for Nexus 5 with Android 6.0.1 and Nextcloud client 3.4.1 and Nextcloud 14 .
However, just to tease you, autoupload works fine with said configuration and Owncloud client 2.7.0 .

@dmnk
Copy link

dmnk commented Jan 22, 2019

Galaxy Tab A (SM-T585) on Android 8.1.0, Security Patch: 01.11.2018
nextcloud (3.4.1) and nextcloud dev (20190117) manually excluded from Samsungs battery saving.

If the productive one is running in split-screen, while the monitored files are changed; it sometimes detects the change and uploads the files.
the dev doesn't even do that.

However, scanning for changes uploads all edited files. no matter which of the two versions or if they've been running during the manipulation / creation.

Update:
Excluded from Androids Battery management as well (Settings, Apps, nextcloud, battery, optimize battery usage -> dont optimize). Still no reproducible sync.

Update:
Sync happened about 10 minutes after change.
At least without external trigger, but giving users a hint what to expect and where to disable what, might help.

I didn't have a deep look into your sources, but wouldn't a https://developer.android.com/reference/android/os/FileObserver implementation remove the need for time-base sync schedules (and delays)? (at least in the client -> server scenario)

@tobiasKaminsky
Copy link
Member

Sync happened about 10 minutes after change.
At least without external trigger, but giving users a hint what to expect and where to disable what, might help.

Glad that it works.
With next version you will see a battery optimization warning when enabling AutoUpload for the first time.
If supported by the Android version, you can then also directly disable it.

@dmnk
Copy link

dmnk commented Jan 22, 2019

already saw that one when starting the dev release the first time.

however, on samsung (and other "not so nice" manufacturer's android derivates) there might be more than one setting to change. And from UI/UX perspective, i'd somehow expect to be informed about a delay, if the sync isn't meant to start right after touching a file.

congrats on still not using the firebase job, even if it might seem that this would solve problems. it got it's own downsides ;)

@tobiasKaminsky
Copy link
Member

Do you have an idea where this info about "not immediately upload" can be shown? Maybe in setting when configuring the individual folder?

@dmnk
Copy link

dmnk commented Jan 22, 2019

I guess that's where i'd put it, as i guess that most people checking their settings are there because it's not working or they'd like to change something.

maybe allow different intervals for different folders?
then it wouldn't be a "notice text"-flying around, but a setting where i see that it's ~quarter-hourly / hourly. ...

But the next one will demand high/low-duty schedules, ... so i guess a text is perfect for now
;D

@metafarion
Copy link

It took me awhile to notice, so I'm not sure when this started happening, but Auto Upload is now working. Android 6.0, LG G4, client 3.4.2.

@tobiasKaminsky
Copy link
Member

@AndyScherzinger are you fine with the idea to put info in the folder settings dialog?

@AndyScherzinger
Copy link
Member

@tobiasKaminsky sure thing, hoping it won't be to much text since the dialog should still have the focus on the settings not on potential warnings/issues. :)

@InfamousUser
Copy link

InfamousUser commented Feb 22, 2019

I cannot get the auto upload to work. After days of being set up and not working and changing settings, somehow today it appeared in uploads menu, but it is apparently blocked by power saver mode. I have power saver mode active whenever I'm not charging. App does not warn anywhere that it will not auto upload in power saver mode.

  1. Please add notification about power saver mode.
  2. Please add a setting to ignore power saver mode for auto uploads.
  3. Please fix whatever is preventing the auto upload from working otherwise.
  4. Please add a button to manually trigger the auto upload as a workaround for emergency situations.
  5. Please add date and time of last successful auto upload.

It still doesn't work with 3.5.1, it seems to only upload files created after enabling autoupload.

@lemmy04
Copy link

lemmy04 commented May 10, 2019

same here: autoupload refuses to autoupload for unknown reasons

@voidzero
Copy link

It's working fine for me now

@bernd-wechner
Copy link

1. Please add notification about power saver mode.
2. Please add a setting to ignore power saver mode for auto uploads.
3. Please fix whatever is preventing the auto upload from working otherwise.
4. Please add a button to manually trigger the auto upload as a workaround for emergency situations.
5. Please add date and time of last successful auto upload.

A good list. As suggested elsewhere I would ad, that it's invaluable to see somewhere int he app:

  1. An indicator of the status of the server connection (live or not)
  2. On the AutoUpload page some indicator on the photo previews as to their status (uploaded, not uploaded) and a way to see a summary of status (tap the thumbnail and get a summary of status, uploaded, yes, or no, when was it uploaded, into which server folder ... last connection to server, reason it's not uploaded yet). A button to request upload now etc.

This kind of transparence would make diagnosing and working around these issues so much simpler.

@lemmy04
Copy link

lemmy04 commented May 10, 2019

Galaxy S8+, camera folder is on SD card, auto upload does NOT work.

I can easily reproduce:

  1. turn off wifi

  2. take picture

  3. turn on wifi

  4. picture from 2. does not get uploaded, and in the list of pending uploads the file is sitting "Waiting for WIFI" even though wifi is connected

  5. turn the phone into FLIGHT MODE

  6. turn off flight mde

  7. file gets uploaded

@lemmy04
Copy link

lemmy04 commented Jun 7, 2019

still the same - see previous comment

@InfamousUser
Copy link

1. Please add notification about power saver mode.
2. Please add a setting to ignore power saver mode for auto uploads.
3. Please fix whatever is preventing the auto upload from working otherwise.
4. Please add a button to manually trigger the auto upload as a workaround for emergency situations.
5. Please add date and time of last successful auto upload.

A good list. As suggested elsewhere I would ad, that it's invaluable to see somewhere int he app:

  1. An indicator of the status of the server connection (live or not)
  2. On the AutoUpload page some indicator on the photo previews as to their status (uploaded, not uploaded) and a way to see a summary of status (tap the thumbnail and get a summary of status, uploaded, yes, or no, when was it uploaded, into which server folder ... last connection to server, reason it's not uploaded yet). A button to request upload now etc.

This kind of transparence would make diagnosing and working around these issues so much simpler.

Great additions!
Number 4 already says about the button - it would help immensely! Even if auto upload doesn't work, people could still make backups until they fix it, should be trivial to add!
So if they added status about all the items that are supposed to be auto uploaded, as you've said, that would be wonderful.

@lemmy04
Copy link

lemmy04 commented Sep 14, 2019

...anyone actually working on fixing this?

@adnoh
Copy link

adnoh commented Nov 12, 2019

This issue ist one of the biggest blocker for a Lot of people to Not use NC. Without a Client which can keep your Files in sync, it is Not really usefull. Has anyone the right amount of Java vodoo to fix this? I mean there ist plenty of Open source sync Software Out There working...maybe one who understands the Code can have a Look how to do it the proper way?

@tobiasKaminsky
Copy link
Member

Is anyone still having this problem? And is willing to install an APK and can give me the logcat?
Then we can try together to hunt this down…

@tobiasKaminsky tobiasKaminsky added needs info Waiting for info from user(s). Issues with this label will auto-stale. and removed approved labels Nov 25, 2020
@InfamousUser
Copy link

Personally I've had the issue because of power saving mode, it didn't want to upload in power saver mode and I didn't know about it because it didn't mention it anywhere in the app.

Nothing to do with the issue itself but adding a "force sync" button to trigger autoupload, and a date of last successful sync somewhere would be very helpful for troubleshooting these issues.

@stale
Copy link

stale bot commented Dec 25, 2020

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@stale stale bot added the stale label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: auto upload needs info Waiting for info from user(s). Issues with this label will auto-stale. stale
Projects
None yet
Development

No branches or pull requests