Merge pull request #5933 from nextcloud-libraries/fix/actions-label

fix(NcActions): Role `menu` needs a label assigned so label by trigger
nextcloud-libraries · Aug 7, 2024 · 60abbab · 60abbab
2 parents ff1072c + 17f5bc1
commit 60abbab
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/components/NcActions/NcActions.vue b/src/components/NcActions/NcActions.vue
@@ -1262,6 +1262,7 @@ export default {
 					},
 					popoverContainerA11yAttrs: {},
 					popoverUlA11yAttrs: {
+						'aria-labelledby': this.triggerRandomId,
 						id: this.randomId,
 						role: 'menu',
 					},
@@ -1311,7 +1312,11 @@ export default {
 					withFocusTrap: true,
 					triggerA11yAttr: {},
 					popoverContainerA11yAttrs: {},
-					popoverUlA11yAttrs: {},
+					popoverUlA11yAttrs: {
+						// there is nothing against labelling a list, it is mostly recommended
+						// so as we do not know the dialog type lets include the label
+						'aria-labelledby': this.triggerRandomId,
+					},
 				},
 			}
 			return configs[this.actionsMenuSemanticType]