Skip to content

Commit

Permalink
fix(NcActions): Role menu needs a label assigned so label by trigger
Browse files Browse the repository at this point in the history
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux committed Aug 6, 2024
1 parent e483f7c commit 17f5bc1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/components/NcActions/NcActions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,7 @@ export default {
},
popoverContainerA11yAttrs: {},
popoverUlA11yAttrs: {
'aria-labelledby': this.triggerRandomId,
id: this.randomId,
role: 'menu',
},
Expand Down Expand Up @@ -1311,7 +1312,11 @@ export default {
withFocusTrap: true,
triggerA11yAttr: {},
popoverContainerA11yAttrs: {},
popoverUlA11yAttrs: {},
popoverUlA11yAttrs: {
// there is nothing against labelling a list, it is mostly recommended
// so as we do not know the dialog type lets include the label
'aria-labelledby': this.triggerRandomId,
},
},
}
return configs[this.actionsMenuSemanticType]
Expand Down

0 comments on commit 17f5bc1

Please sign in to comment.