Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug steps to narrow the source of newrelic+graphql-core performance regression #830

Closed
wants to merge 33 commits into from
Closed

Debug steps to narrow the source of newrelic+graphql-core performance regression #830

wants to merge 33 commits into from

Conversation

tdg5
Copy link

@tdg5 tdg5 commented Jun 13, 2023

No description provided.

Danny Guinther added 30 commits June 12, 2023 12:25
Short-circuit wrap_execute_operation
8eea9e0
Bypass graphql wrap_resolve_field
00f8fa1
Bypass graphql wrap_resolver
a2684e1
Bypass instrument_graphql_execute
8b46f40
Bypass only wrap_resolve_field
63a245a
Bypass wrap_execute_operation
a063c94
Bypass wrap_execute_operation
a2851ff
Disable by other means
5b85745
Reintroduce graphene hooks
f31c536
Kill graphene, add graphql hook newrelic#1
44f39d0
Kill graphql hook newrelic#1, add graphql hook newrelic#2
dcf409b
Kill graphql hook newrelic#2, add graphql hook newrelic#3
b21bc15 
graphql hook newrelic#2 DID cause the regression
Kill graphql hook newrelic#3, add graphql hook newrelic#4
d79ddb1 
graphql hook newrelic#3 DID NOT cause the regression
Kill graphql hook newrelic#4, add graphql hook newrelic#5
4eb82dc 
graphql hook newrelic#4 DID NOT cause the regression
Kill graphql hook newrelic#5, add graphql hook newrelic#6-newrelic#12
c31be5d 
graphql hook newrelic#5 DID NOT cause the regression
Reactivate regression
e179d0b 
Graphql hooks newrelic#6-newrelic#12 DID NOT cause the regression
Bypass all instrument_graphql_execute except wrap_get_field_def
942d1c9
Disable wrap_get_field_def, enable wrap_resolve_field
750e023 
wrap_get_field_def DOES contribute to the regression
Disable wrap_resolve_field, enable wrap_execute_operation
4745f18 
wrap_resolve_field DID NOT contribute to the regression
Disable wrap_execute_operation, enable all ExecutionContext wrappers
e52981f 
wrap_execute_operation DID NOT contribute to the regression
ExecutionContext wrappers DID contribute to regression. Which one?
2edd858
Disable wrap_get_field_def, enable wrap_resolve_field
03a7bca 
wrap_get_field_def DID NOT contribute to the regression
Disable wrap_resolve_field, enable wrap_execute_operation
99bd706 
wrap_resolve_field DID contribute to the regression
Disable wrap_execute_operation, re-enable wrap_resolve_field and
a762ab4 
wrap_get_field_def

wrap_execute_operation DID NOT contribute to the regression
Add a hi
ee396f4
Double check attr set
e037372
Short-circuit wrap_resolver
bced910
Shortcircuit before traces
458c3ab
Short circuit after transaction check
f2252ac
Immediate short-circuit
3797549
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdg5 @CLAassistant @umaannamalai