-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASGI - Starlette/Fast API Framework #5
Comments
Glad to see this. Starlette is an amazing framework and is, in conjunction with fastapi, seeing a lot of adoption. Just in case you're planning to leverage exclusively |
There's a bug in previous version that I assume it's happening only in FastAPI. I opened this issue. |
graphql hook newrelic#4 DID NOT cause the regression
graphql hook newrelic#5 DID NOT cause the regression
Overview:
Starlette is a lightweight ASGI framework/toolkit, which is ideal for building high performance asyncio services. It supports both HTTP and WebSockets. With over 500K downloads a month, it is growing rapidly in popularity: https://pypistats.org/packages/starlette
Currently, customers will not see see data in NR when monitoring their Starlette ASGI application. This MMF addresses this, giving those customers visibility their transactions and downstream services.
The key is to show transactions data and ensure they can also view those transactions are viewable in DT.
Acceptance Criteria:
Extract and send web-transaction events (start/end time) for http requests (not web sockets since they do not create transactions, since this can cause memory explosion for long-running transactions)
Attach appropriate attributes to those events i.e.
Send span event data / trace id? (goal here to to ensure those transactions translate to a span and there is an id that is passed from the transaction to the external service so we can track them in DT view.
Add to New Relic docs and website that we offer Starlette support
Units Tests
Demo
The text was updated successfully, but these errors were encountered: