Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[super-agent] typo fixes so codespell stops yelling #1382

Merged
merged 5 commits into from
May 30, 2024
Merged

Conversation

csongnr
Copy link
Contributor

@csongnr csongnr commented May 29, 2024

Is this a new chart

no

What this PR does / why we need it:

just fixes some typos

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

don't think this requires a chart version to be bumped but I can if needed

@csongnr csongnr requested a review from a team May 29, 2024 17:21
@dbudziwojskiNR dbudziwojskiNR requested a review from a team May 29, 2024 23:16
@dbudziwojskiNR dbudziwojskiNR changed the title [super agent] some typo fixes so codespell stops yelling [super-agent] some typo fixes so codespell stops yelling May 29, 2024
@dbudziwojskiNR dbudziwojskiNR changed the title [super-agent] some typo fixes so codespell stops yelling fix: Typo fixes so codespell stops yelling May 29, 2024
@dbudziwojskiNR dbudziwojskiNR changed the title fix: Typo fixes so codespell stops yelling [super-agent] typo fixes so codespell stops yelling May 29, 2024
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
To bump the version I'd bump the patch. You might want to sync with @paologallinaharbur (#1379).
You can check it for instance from this PR

@csongnr csongnr merged commit dff2594 into master May 30, 2024
11 checks passed
@csongnr csongnr deleted the cs/fix-spelling branch May 30, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants