Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[super-agent] remove jobs #1379

Merged
merged 6 commits into from
Jun 6, 2024
Merged

[super-agent] remove jobs #1379

merged 6 commits into from
Jun 6, 2024

Conversation

paologallinaharbur
Copy link
Member

Is this a new chart

no

What this PR does / why we need it:

Right now we do not have auto=upgrade in place, therefore it is better to install in the dependency in an easy way.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@paologallinaharbur paologallinaharbur requested a review from a team May 27, 2024 12:53
@paologallinaharbur paologallinaharbur requested a review from a team May 27, 2024 13:02
@paologallinaharbur paologallinaharbur force-pushed the feat/removeJobs branch 2 times, most recently from 9fde36e to 2a92140 Compare May 27, 2024 15:44
@paologallinaharbur
Copy link
Member Author

The upgrade path is failing since we are introducing a breaking change and the tool is not smart enough to detect it 😄

Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

charts/super-agent/README.md Show resolved Hide resolved
Copy link
Contributor

@kilokang kilokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

charts/super-agent/README.md Outdated Show resolved Hide resolved
@paologallinaharbur paologallinaharbur merged commit eecef6e into master Jun 6, 2024
10 of 11 checks passed
@paologallinaharbur paologallinaharbur deleted the feat/removeJobs branch June 6, 2024 13:51
@@ -3,8 +3,6 @@
{{ template "chart.header" . }}
{{ template "chart.deprecationWarning" . }}

{{ template "chart.badgesSection" . }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants