Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify default mixing parameter only #327

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Specify default mixing parameter only #327

merged 3 commits into from
Jan 30, 2020

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Jan 28, 2020 •
edited
Loading

This requires mantid PR27809 before the pseudo-Voigt will actually work. However, this change won't break the currently working Gaussian peak fitting so it is safe to merge.

Fixes #293

@peterfpeterson peterfpeterson added the bug Something isn't working label Jan 28, 2020
@peterfpeterson peterfpeterson force-pushed the 293_pseudo_voigt_mixing branch 2 times, most recently from d03117c to 5750ced Compare January 30, 2020 15:21
@peterfpeterson peterfpeterson force-pushed the 293_pseudo_voigt_mixing branch from 5750ced to f111db1 Compare January 30, 2020 15:41
@peterfpeterson peterfpeterson mentioned this pull request Jan 30, 2020
Closed
@peterfpeterson
Copy link
Member Author

#337 was created to remove the pytest.mark.skipif on the build server

@peterfpeterson peterfpeterson merged commit d141b13 into master Jan 30, 2020
@peterfpeterson peterfpeterson deleted the 293_pseudo_voigt_mixing branch January 30, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve fitting
1 participant
@peterfpeterson