Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework pkg/registry to use clock.Clock #784

Merged
merged 6 commits into from
Apr 22, 2021
Merged

Rework pkg/registry to use clock.Clock #784

merged 6 commits into from
Apr 22, 2021

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Mar 23, 2021 •
edited
Loading

Depends on #782.

@Bolodya1997 Bolodya1997 force-pushed the clock-registry branch 2 times, most recently from be37c5d to 9511914 Compare March 23, 2021 11:42
@Bolodya1997 Bolodya1997 mentioned this pull request Mar 23, 2021
Open
@Bolodya1997 Bolodya1997 force-pushed the clock-registry branch 3 times, most recently from d09b467 to 2ab256a Compare March 26, 2021 11:01
@Bolodya1997 Bolodya1997 marked this pull request as ready for review March 26, 2021 11:20
@denis-tingaikin denis-tingaikin self-requested a review March 29, 2021 06:18
@Bolodya1997 Bolodya1997 mentioned this pull request Mar 29, 2021
Closed
@Bolodya1997 Bolodya1997 marked this pull request as draft April 6, 2021 02:04
@Bolodya1997 Bolodya1997 marked this pull request as ready for review April 6, 2021 02:29
@Bolodya1997 Bolodya1997 force-pushed the clock-registry branch 6 times, most recently from 771a107 to e5ce34c Compare April 19, 2021 07:07
Vladimir Popov added 5 commits April 22, 2021 12:10
Rework registry/querycache to clock
9829c91 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Rework registry/expire to clock
cf4fe51 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Rework registry/connect to clock
261e023 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Rework registry/refresh to clock
e78ddf5 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Remove time.Sleep from clocked registry tests
df12876 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Remove clockMock.IsTimerSet
2f577e1 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@denis-tingaikin denis-tingaikin merged commit 8fe3d10 into networkservicemesh:main Apr 22, 2021
@Bolodya1997 Bolodya1997 deleted the clock-registry branch June 16, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin Awaiting requested review from denis-tingaikin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @denis-tingaikin