Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clock #782

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Add Clock #782

merged 3 commits into from
Mar 26, 2021

Conversation

Bolodya1997
Copy link

Adds clock.Clock interface for accessing time and clock.Mock for mocking time - #764.

Vladimir Popov added 2 commits March 23, 2021 12:14
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very like this direction :)

@Bolodya1997 Should we put mocks into separate pkg to exclude them from cmd-*?

pkg/tools/clock/context.go Outdated Show resolved Hide resolved
pkg/tools/clock/context.go Outdated Show resolved Hide resolved
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997
Copy link
Author

@Bolodya1997 Should we put mocks into separate pkg to exclude them from cmd-*?

Yes, it is a good idea. Moved to clockmock.

@denis-tingaikin denis-tingaikin merged commit 18c7663 into networkservicemesh:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants