Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating metal-lb ip-address pool definition #235

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

arora-sagar
Copy link
Contributor

  • This is needed for the oai exercise document.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # Currently in the exercise document for OAI, there is no method to define metal-lb ip-address pool for workload clusters. In R2 even workload clusters use metal lb as NRF exposes its service via Metal LB for UPF to register.

Special notes for your reviewer:

Breaking 001-infra.sh in two parts was a easier choice than renaming all the scripts.

Does this PR introduce a user-facing change?:

NONE

- This is needed for the oai exercise document.
@arora-sagar
Copy link
Contributor Author

/retest-required

@electrocucaracha
Copy link
Member

@arora-sagar I think that you have to rename the 001 bash scripts differently. Like 001b-infra-metal-lb.sh and 001a-infra.sh

@electrocucaracha
Copy link
Member

electrocucaracha commented Feb 2, 2024

@tliron I'll trigger another execution to confirm that it's not broken with the latest changes.

/test e2e-free5gc-fedora-34

@arora-sagar
Copy link
Contributor Author

@electrocucaracha I don't understand the reason now for the failure. It failed once that is okay but now I tested manually the scripts and I don't get the error because of the networking script. Earlier I had cluster section missing

declare -A clusters
clusters=(
    ["core"]="172.18.16.0/20"
    ["regional"]="172.18.32.0/20"
    ["edge"]="172.18.48.0/20"
)

But when I added it the run still showed me the same error as the previous commit. Can you help me understand this?

@arora-sagar
Copy link
Contributor Author

/retest

@radoslawc
Copy link
Collaborator

/approve
/lgtm

@electrocucaracha
Copy link
Member

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [electrocucaracha,radoslawc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@electrocucaracha
Copy link
Member

/retest

@nephio-prow nephio-prow bot merged commit f58697d into nephio-project:main Feb 2, 2024
5 checks passed
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
* Separating metal-lb ip-address pool definition

- This is needed for the oai exercise document.

* Renaming the infra tests

* renaming the script name for tests

* Adding back cluster definition in infra script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants