Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user guides instructions #102

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

electrocucaracha
Copy link
Member

This PR fixes some instructions describe in the Free5GC and OAI user guides, removes some trail spaces, and simplifies the get logs instructions.

@rravindran123
Copy link
Contributor

When I tested yesterday, the UPF was stuck in the Init stage, @arora-sagar mentioned the documentation didnt cover the step to include the MetalLb ip-address pool configuration. Hope that is taken care off in this PR, haven't validated the testing against this updated instructions yet.

@arora-sagar
Copy link
Contributor

arora-sagar commented Feb 1, 2024

Thanks for this PR.

I just did the testing and the comments are based on that testing for metal lb. I have to do another PR and add a section after networking to run the script ./test-infra/e2e/tests/oai/001-infra-metal-lb.sh in test-infra I will detach it from 001-infra.sh and make it a sub test of 001 test.

@arora-sagar
Copy link
Contributor

I did the PR here for metal-lb issue --> nephio-project/test-infra#235

Signed-off-by: Victor Morales <v.morales@samsung.com>
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Feb 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 3, 2024
@nephio-prow nephio-prow bot merged commit 50fead4 into nephio-project:main Feb 3, 2024
4 checks passed
@electrocucaracha electrocucaracha deleted the fix_user-guides branch February 3, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants