-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import kubeconfig creation into Ansible Role #105
Import kubeconfig creation into Ansible Role #105
Conversation
Seems OK, I don't know enough about Ansible to understand why the |
That's right, basically |
Would this make sense post R1 and we can document it meanwhile? |
I have seen some benefits in terms of CI execution. Ansible constantly sends messages which are captured by Terraform as progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed only, not tested.
/lgtm
e156c1f
to
3e62328
Compare
3e62328
to
a4c26ca
Compare
a4c26ca
to
330380e
Compare
@@ -47,8 +47,23 @@ | |||
when: not 'kind' in bootstrap_kind_get_cluster.stdout | |||
changed_when: true | |||
|
|||
- name: Create gitea namespace | |||
- name: Create .kube directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, radoslawc, vjayaramrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@radoslawc: Overrode contexts on behalf of radoslawc: e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Nephio management cluster is created with
root
user during the execution of thebootstrap
Ansible role. As a consequence, many tasks have to be executed with elevated permissions. An initial workaround was to fix it after the Ansible execution. This change removes that workaround and includes those instructions as part of thebootstrap
process.