Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import kubeconfig creation into Ansible Role #105

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

electrocucaracha
Copy link
Member

The Nephio management cluster is created with root user during the execution of the bootstrap Ansible role. As a consequence, many tasks have to be executed with elevated permissions. An initial workaround was to fix it after the Ansible execution. This change removes that workaround and includes those instructions as part of the bootstrap process.

@johnbelamaric
Copy link
Member

Seems OK, I don't know enough about Ansible to understand why the become: true statements are being remooved. Or to really review this with any authority, honestly. But from what I understand this seems reasonable.

@electrocucaracha
Copy link
Member Author

Seems OK, I don't know enough about Ansible to understand why the become: true statements are being remooved. Or to really review this with any authority, honestly. But from what I understand this seems reasonable.

That's right, basically become Ansible instruction is similar than sudo. Hopefully we can minimize the places where we need permissions.

@vjayaramrh
Copy link
Collaborator

Would this make sense post R1 and we can document it meanwhile?

@electrocucaracha
Copy link
Member Author

Would this make sense post R1 and we can document it meanwhile?

I have seen some benefits in terms of CI execution. Ansible constantly sends messages which are captured by Terraform as progress.

Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed only, not tested.
/lgtm

@@ -47,8 +47,23 @@
when: not 'kind' in bootstrap_kind_get_cluster.stdout
changed_when: true

- name: Create gitea namespace
- name: Create .kube directory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, radoslawc, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 23, 2023
@radoslawc
Copy link
Collaborator

/lgtm
/override e2e

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 23, 2023

@radoslawc: Overrode contexts on behalf of radoslawc: e2e

In response to this:

/lgtm
/override e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nephio-prow nephio-prow bot merged commit bd1d84a into nephio-project:main Jun 23, 2023
@electrocucaracha electrocucaracha deleted the fix_kind_creation branch June 23, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants