Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore sandbox #24

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Explore sandbox #24

merged 5 commits into from
Jun 23, 2023

Conversation

liamfallon
Copy link
Member

No description provided.

Signed-off-by: liamfallon <liam.fallon@est.tech>
@nephio-prow nephio-prow bot requested review from s3wong and tliron June 20, 2023 12:52
@liamfallon
Copy link
Member Author

Copy link
Contributor

@lapentad lapentad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .drawio file supposed to be there?

@liamfallon
Copy link
Member Author

@lapentad yes, it's the draw.io source file that the .png was generated from. It's there so that the diagram can be modified later.

Copy link
Member

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @liamfallon, thanks for capturing and describing the process. I just found a typo, besides that everything looks good.

<summary>You can check the status of an applied kpt package using a "kpt live status package_dir" command.</summary>

```
sudo kpt live status /tmp/kpt-pkg/nephio-controllers/
Copy link
Member

@electrocucaracha electrocucaracha Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will allow running things without sudo. We can merge this document as it is and change it once the other PR is approved.

Suggested change
sudo kpt live status /tmp/kpt-pkg/nephio-controllers/
kpt live status /tmp/kpt-pkg/nephio-controllers/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

| Postgres | Used by Gitea to store repositories |
| Cluster CAPI | Used deploy kind workload clusters |
| IPAM | A system used to allocate and manage IP addresses |
| VLAM | A system used to allocate and manage VLANs |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| VLAM | A system used to allocate and manage VLANs |
| VLAN | A system used to allocate and manage VLANs |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggested edit. Overall looks very helpful.

<summary>Querying the k8s pods running after the install produces output similar to:</summary>

```
$ kubectl get pods -A
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight improvement if you don't need the kube-system pods

kubectl get pods -A --field-selector=metadata.namespace!=kube-system

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

learning.md Outdated
* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange
* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved free5gc operator from Orange

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 21, 2023
Copy link
Contributor

@gvbalaji gvbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liamfallon for the nice write up. Added couple of comments.


## Base Components

The following base components are installed on the kind management cluster. Base components are standard components in the k8s ecosystem, which Nephio uses out of the box.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of saying "Base components are standard components in the k8s ecosystem," we could say "Base components are the infrastructure components that are needed for the Nephio sandbox"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gvbalaji I reworded the document along the lines you suggested.

| Gitea | Used to allow creation and management of local git repos by Nephio |
| Postgres | Used by Gitea to store repositories |
| Cluster CAPI | Used deploy kind workload clusters |
| IPAM | A system used to allocate and manage IP addresses |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPAM and VLAN backends are more like reference implementations that we use. In real world customers may use something else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this as well.

@nephio-prow nephio-prow bot removed the lgtm label Jun 22, 2023
@liamfallon
Copy link
Member Author

Could we nudge this on please?

@henderiw
Copy link
Contributor

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jun 23, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 23, 2023
@nephio-prow nephio-prow bot merged commit dab9687 into nephio-project:main Jun 23, 2023
@liamfallon liamfallon deleted the explore-sandbox branch June 26, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants