-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore sandbox #24
Explore sandbox #24
Conversation
/assign @electrocucaracha @efiacor @lapentad @henderiw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .drawio file supposed to be there?
@lapentad yes, it's the draw.io source file that the .png was generated from. It's there so that the diagram can be modified later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @liamfallon, thanks for capturing and describing the process. I just found a typo, besides that everything looks good.
install-guide/ExploreSandbox.md
Outdated
<summary>You can check the status of an applied kpt package using a "kpt live status package_dir" command.</summary> | ||
|
||
``` | ||
sudo kpt live status /tmp/kpt-pkg/nephio-controllers/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will allow running things without sudo
. We can merge this document as it is and change it once the other PR is approved.
sudo kpt live status /tmp/kpt-pkg/nephio-controllers/ | |
kpt live status /tmp/kpt-pkg/nephio-controllers/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
install-guide/ExploreSandbox.md
Outdated
| Postgres | Used by Gitea to store repositories | | ||
| Cluster CAPI | Used deploy kind workload clusters | | ||
| IPAM | A system used to allocate and manage IP addresses | | ||
| VLAM | A system used to allocate and manage VLANs | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| VLAM | A system used to allocate and manage VLANs | | |
| VLAN | A system used to allocate and manage VLANs | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggested edit. Overall looks very helpful.
install-guide/ExploreSandbox.md
Outdated
<summary>Querying the k8s pods running after the install produces output similar to:</summary> | ||
|
||
``` | ||
$ kubectl get pods -A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight improvement if you don't need the kube-system pods
kubectl get pods -A --field-selector=metadata.namespace!=kube-system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
learning.md
Outdated
* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange | |
* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved free5gc operator from Orange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liamfallon for the nice write up. Added couple of comments.
install-guide/ExploreSandbox.md
Outdated
|
||
## Base Components | ||
|
||
The following base components are installed on the kind management cluster. Base components are standard components in the k8s ecosystem, which Nephio uses out of the box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of saying "Base components are standard components in the k8s ecosystem," we could say "Base components are the infrastructure components that are needed for the Nephio sandbox"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvbalaji I reworded the document along the lines you suggested.
install-guide/ExploreSandbox.md
Outdated
| Gitea | Used to allow creation and management of local git repos by Nephio | | ||
| Postgres | Used by Gitea to store repositories | | ||
| Cluster CAPI | Used deploy kind workload clusters | | ||
| IPAM | A system used to allocate and manage IP addresses | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPAM and VLAN backends are more like reference implementations that we use. In real world customers may use something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this as well.
Could we nudge this on please? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, henderiw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.