-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing base URL for R2 #135
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
✅ Deploy Preview for nephio-r2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I downloaded this PR to test it but when I ran
|
@@ -1,4 +1,4 @@ | |||
baseURL = 'https://nephio.org/' | |||
baseURL = 'https://r2.docs.nephio.org/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these will tie in to the drop down menu when it gets merged right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, my mistake, I pulled the wrong PR. |
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
c6befd2
to
69c79e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixing the 404 issue of the breadcrumb navigation in R2.
/assign @efiacor @liamfallon
This supposed to fix the issue for the R2 branch pointed out by @efiacor in #128 (review)
As an extra I'm adding the link fixes to R2 merged to main in #130 (69c79e2)
Link checks for the LFN Wiki are disabled as the wiki is down. LF IT ticket was created.