Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding versioning support to R2 #133

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented Jun 6, 2024

Redoing #132 now without merging the main branch to the R2 one.

Partly fixes nephio-project/nephio#738

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@nephio-prow nephio-prow bot requested review from henderiw and tliron June 6, 2024 05:40
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 9e1ea13
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/666991aa2bf9a2000851a59b
😎 Deploy Preview https://deploy-preview-133--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CsatariGergely
Copy link
Contributor Author

/assign @liamfallon @ciaranjohnston

our [Learning Nephio with R1](https://wiki.nephio.org/display/HOME/Learning+with+Nephio+R1) series, which includes a
[demo video](https://youtu.be/mFl71sy2Pdc) and short articles about different aspects of Nephio R1.
{{% blocks/feature icon="fas fa-rocket" title="R2" %}}
Welcome to the R2 release of Nephio. Please use the documentation links below to learn more about Nephio R2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CsatariGergely Shouldn't we be in sync with cover title "Welcome to Release 2 of Nephio" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9e1ea13

I've added a reference to 'R2' also as this is the short name of the release what everyone is using.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I am fine with this

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me once the comment from @arora-sagar is resolved.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Contributor Author

Partially fixes #738

@arora-sagar
Copy link
Contributor

Partially fixes #738

I suppose we can approve this PR once --> #128 is merged

@liamfallon
Copy link
Member

/retest

@CsatariGergely CsatariGergely changed the base branch from main to R2 June 13, 2024 13:35
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for nephio-r2 ready!

Name Link
🔨 Latest commit e435b83
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r2/deploys/666af61ece0cb9000864b1f5
😎 Deploy Preview https://deploy-preview-133--nephio-r2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamfallon
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jun 17, 2024
Copy link
Contributor

nephio-prow bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 17, 2024
@nephio-prow nephio-prow bot merged commit 4d63902 into nephio-project:R2 Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versioning support to the documentation
4 participants