-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding versioning support to R2 #133
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @liamfallon @ciaranjohnston |
content/en/_index.md
Outdated
our [Learning Nephio with R1](https://wiki.nephio.org/display/HOME/Learning+with+Nephio+R1) series, which includes a | ||
[demo video](https://youtu.be/mFl71sy2Pdc) and short articles about different aspects of Nephio R1. | ||
{{% blocks/feature icon="fas fa-rocket" title="R2" %}} | ||
Welcome to the R2 release of Nephio. Please use the documentation links below to learn more about Nephio R2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CsatariGergely Shouldn't we be in sync with cover title "Welcome to Release 2 of Nephio" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9e1ea13
I've added a reference to 'R2' also as this is the short name of the release what everyone is using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I am fine with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with me once the comment from @arora-sagar is resolved.
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Partially fixes #738 |
/retest |
✅ Deploy Preview for nephio-r2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Redoing #132 now without merging the main branch to the R2 one.
Partly fixes nephio-project/nephio#738