Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request extension files and libraries from compute_ctl v14 #289

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

lubennikovaav
Copy link

postres part of neondatabase/neon#4592

@lubennikovaav lubennikovaav changed the title Request extension files and libraries from compute_ctl Request extension files and libraries from compute_ctl v14 Jun 29, 2023
@lubennikovaav lubennikovaav requested a review from hlinnaka June 29, 2023 16:10
Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to implement this with DDL event triggers or as a ProcessUtility hook?

@lubennikovaav
Copy link
Author

lubennikovaav commented Jul 4, 2023

Would it be possible to implement this with DDL event triggers or as a ProcessUtility hook?

Well, I think it is not absolutely impossible, but why?

This approach will require to repeat most of these functions:

  • First, we'll need to parse control file to figure out extension directory (if any), library name and path and so on.
  • Second, we'll need to check if files are present on disk.
  • Then request them from remote extension server.
  • And finally try to read file locally again.

So, I decided to add small patch to existing code instead.
All changes are inside in if (download_extension_file_hook != NULL) to ensure that it doesn't affect normal execution.

@lubennikovaav lubennikovaav merged commit 28bf5cc into REL_14_STABLE_neon Aug 1, 2023
@lubennikovaav lubennikovaav deleted the extension_loading_v14 branch August 1, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants