-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tar Remote Extensions #4715
Tar Remote Extensions #4715
Conversation
1264 tests run: 1213 passed, 0 failed, 51 skipped (full report) |
For local testing / testing on staging, the most relevant metric to look at is
(because shared preload libraries are loaded during |
@cicdteam is working on improving the infra for this: https://github.com/neondatabase/aws/pull/405#issue-1804986517 |
Note: tests with real S3 are expected to fail right now because we haven't uploaded the necessary files to S3 yet. |
TODO: Merge postgres changes:
Control Plane changes:
Upload files to S3 via
Infra changes:
|
This need to solve to allow computes access to S3 buckets (extension storage) |
cced72a
to
63d5d6c
Compare
it looks like the first round trip to AWS is really expensive even if it's downloading a really small file? like ~3KB |
512f010
to
d82987f
Compare
pretty sure the cloud test failures are unrelated |
Co-authored-by: Anastasia Lubennikova <anastasia@neon.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about a couple potential changes. nothing major
as needed since #4715 or this will happen: ``` ERROR panic{thread=main location=.../hyper-rustls-0.23.2/src/config.rs:48:9}: no CA certificates found ```
Add support for remote extensions. When requested, downloads a
tar.gz
file for the extension and then organizes the contained files. For instance, placing.so
files insharelib
.