-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: neon new
not exiting on windows
#537
Merged
dherman
merged 9 commits into
neon-bindings:master
from
amilajack:fix/updated-windows-cli-fix
Jul 18, 2020
Merged
fix: neon new
not exiting on windows
#537
dherman
merged 9 commits into
neon-bindings:master
from
amilajack:fix/updated-windows-cli-fix
Jul 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `neon new` could not be comple in Windows - Update packages
Other than the question about |
dherman
approved these changes
Jul 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have two tiny suggestions about the use of existsSync
, but they're up to you.
neon new
not exiting on windowsneon new
not exiting on windows
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406
Closes #501
This bug fixes a bug where running
neon new
on windows will hang without ever exiting despite creating a new repo and all.Changes
make-promises-safe
to CLI entrypoint to ensure promise do not silently failts-unknown
andes6-polyfill
dependenciesTesting this PR
Make sure you're on a windows machine to test this PR
git clone https://github.com/neon-bindings/neon test-repo cd test-repo npm i npm run transpile node bin/cli.js new foo
This fix is based on @usagi 's PR (#501). Thanks!