Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: neon new not exiting on windows #537

Merged
merged 9 commits into from
Jul 18, 2020

Conversation

amilajack
Copy link
Member

@amilajack amilajack commented Jul 3, 2020

Fixes #406
Closes #501

This bug fixes a bug where running neon new on windows will hang without ever exiting despite creating a new repo and all.

Changes

  • Migrates to use native fs module
  • Bumps TS to latest version
  • Adds make-promises-safe to CLI entrypoint to ensure promise do not silently fail
  • Build targets ES6
  • Removes node 8 from CI, adds node 14
  • Removes ts-unknown and es6-polyfill dependencies
  • Change methods to sync

Testing this PR

Make sure you're on a windows machine to test this PR

git clone https://github.com/neon-bindings/neon test-repo
cd test-repo
npm i
npm run transpile
node bin/cli.js new foo

This fix is based on @usagi 's PR (#501). Thanks!

@amilajack amilajack marked this pull request as ready for review July 4, 2020 01:06
@goto-bus-stop
Copy link
Member

Other than the question about unlink, this looks good to me! Works as expected on my Win10 machine. Love the addition of make-promises-safe too :)

Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have two tiny suggestions about the use of existsSync, but they're up to you.

@dherman dherman mentioned this pull request Jul 12, 2020
6 tasks
@amilajack amilajack changed the title fix neon new not exiting on windows fix: neon new not exiting on windows Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neon new and build failed on Node11.10.1 Win10
4 participants