Switch to GitHub Actions #531

lhr0909 · 2020-06-21T02:26:01Z

Resolves #528

Run cargo test with a NodeJS version matrix and Rust toolchain matrix
Specific environment dependencies (apt dependencies etc)
Electron settings
Generate Documentation
Windows build
MacOS build

lhr0909 · 2020-06-21T02:29:34Z

Currently build is being run on my fork: https://github.com/lhr0909/neon/actions

amilajack · 2020-07-03T17:59:58Z

Your CI seems to be failing on linux builds because its timing out. Any ideas for why that might be?

lhr0909 · 2020-07-08T23:57:16Z

https://github.com/lhr0909/neon/actions/runs/143132073 I think I resolved that @amilajack I believe it failed because of the electron set up wasn't there.

lhr0909 · 2020-07-09T10:55:37Z

https://github.com/lhr0909/neon/actions/runs/163149424 docs workflow is ready to go now.

kjvalencik · 2020-07-09T15:39:11Z

.github/workflows/docs.yml

@@ -0,0 +1,28 @@
+name: Generate Docs


@dherman @amilajack Do we use Github Pages for docs anymore? I thought we switched to only using docs.rs?

Yea we do. I think the domain is hosted with netlify. But our static content for the site is hosted with gh pages. Cargo generated API docs are hosted on docs.rs.

lhr0909 · 2020-07-09T15:49:09Z

https://github.com/lhr0909/neon/runs/854609942?check_suite_focus=true#step:6:388 I got very close to resolve the Windows build but seems like there is a 60 seconds timeout.

amilajack · 2020-07-10T17:42:53Z

.github/workflows/linux.yml

+
+    strategy:
+      matrix:
+        node-version: [8.x, 10.x, 12.x]


We're okay with dropping support for node 8. We can change this to [10.x, 12.x, 14.x] and that might make this CI pass. We can also do this for other workflows as well

lhr0909 · 2020-07-12T03:15:21Z

https://github.com/lhr0909/neon/runs/854609942?check_suite_focus=true#step:6:416

https://github.com/lhr0909/neon/runs/862005882?check_suite_focus=true#step:6:417

Actually, after looking into the test further, seems like it is failing at the tests::cli_test, and it doesn't seem to be a consistent repro.

dherman · 2020-07-12T19:18:04Z

@lhr0909 I suspect this has to do with some recent Windows build problems (#406, #501), which we think are fixed with #537. I've reviewed #537 today and we should be able to merge it soon, and then let's see if that just makes these issues here go away. :)

dherman · 2020-07-12T19:22:41Z

Getting excited……………

lhr0909 · 2020-07-12T23:55:42Z

@dherman Thanks Dave! Let me know if we would like to do the MacOS workflow, I can try to set it up.

dherman · 2020-07-13T16:56:17Z

@lhr0909 A macOS workflow would be great, yes! 😄

lhr0909 · 2020-07-18T13:55:14Z

https://github.com/lhr0909/neon/actions/runs/173784987 I just rebased on latest master and seems like the Windows test passed.

lhr0909 · 2020-07-18T14:03:34Z

Tests pass. Going to remove Appveyor and Travis from my branch.

lhr0909 · 2020-07-18T14:20:36Z

I think I have removed Appveyor file from the branch, but not sure why there is still a check

kjvalencik · 2020-07-18T14:45:16Z

Appveyer will continue to build until it's merged.

dherman

This is incredible. It's so readable and simple, and consistent across all three platforms. Amazing work!

I'm approving but it would be good to get @kjvalencik's review as well, since he's worked on our CI in the past as well.

dherman · 2020-07-18T19:23:24Z

.github/workflows/docs.yml

+    - name: Push docs to gh-pages branch
+      uses: JamesIves/github-pages-deploy-action@releases/v3
+      with:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


I'm curious how this works. Does GitHub automatically give you this, or did we already have a secret called GITHUB_TOKEN installed somewhere in the repo settings? I couldn't find anything in the repo's settings tab.

GitHub automatically gives it to you. It has limited permissions and a short TTL. It's one of the best features of actions. ❤️

amilajack · 2020-07-18T21:01:42Z

Is it possible to consolidate these configs into a single config?

lhr0909 · 2020-07-19T00:19:16Z

@amilajack I can make them into a single config, just that we will still end up having this long list of checks because of the node version matrix, rust toolchain versions, and platforms. Also, the conditional logic in a single config will be hard to maintain (for example, docs and xvfb setup on Linux for Electron test). Separate files are easier if we are going to see this long list of checks anyway.

.github/workflows/docs.yml

.github/workflows/linux.yml

Co-authored-by: K.J. Valencik <kjvalencik@gmail.com>

dherman · 2020-08-01T17:40:33Z

@lhr0909 Thanks for updating! It looks like there are a couple of build failures. I think the Appveyor one doesn't matter since we'll disable it. Do the Actions failures matter or do you think we can merge?

kjvalencik · 2020-08-01T17:52:50Z

@dherman It looks like it might be a legitimate test failure on node 14 + windows and not related to actions. The others are cancelled builds because of that failed build.

kjvalencik · 2020-08-01T17:56:26Z

@dherman Looks like the failed build is the neon new bug that @amilajack's PR fixes.

I think this is good to merge.

kjvalencik · 2020-08-01T18:10:06Z

@lhr0909 Thanks for rh awesome contribution! I'm exited about this build matrix!

dherman · 2020-08-01T18:26:49Z

Thank you @lhr0909!!

kjvalencik reviewed Jul 9, 2020

View reviewed changes

amilajack reviewed Jul 10, 2020

View reviewed changes

lhr0909 added 9 commits July 18, 2020 21:25

test github action

0b5a5ea

fixed the build trigger

2ef84d2

added electron test

c64a39a

added docs workflow

068ba22

trying out windows build

5394657

trying to use msvs 2019 and see if it passes

0491055

updating node-gyp version to get around the electron download error

a9f9d64

update electron version to fix the node-gyp issue in windows

b5f84f4

dropping nodejs 8.x and adding nodejs 14.x

7f0a04c

lhr0909 force-pushed the master branch from 8528cb2 to 7f0a04c Compare July 18, 2020 13:25

added macos test

5e0a4e1

added workflow trigger on pull_request, removed travis and appveyor

3067a25

lhr0909 changed the title ~~[WIP] Switch to GitHub Actions~~ Switch to GitHub Actions Jul 18, 2020

dherman approved these changes Jul 18, 2020

View reviewed changes

dherman requested a review from kjvalencik July 18, 2020 20:36

kjvalencik requested changes Jul 24, 2020

View reviewed changes

.github/workflows/docs.yml Outdated Show resolved Hide resolved

.github/workflows/linux.yml Outdated Show resolved Hide resolved

lhr0909 and others added 2 commits August 1, 2020 10:39

Update .github/workflows/docs.yml

354fe43

Co-authored-by: K.J. Valencik <kjvalencik@gmail.com>

Update .github/workflows/linux.yml

f91b12b

Co-authored-by: K.J. Valencik <kjvalencik@gmail.com>

kjvalencik approved these changes Aug 1, 2020

View reviewed changes

kjvalencik merged commit f70f4b8 into neon-bindings:master Aug 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to GitHub Actions #531

Switch to GitHub Actions #531

lhr0909 commented Jun 21, 2020 •

edited

Loading

lhr0909 commented Jun 21, 2020

amilajack commented Jul 3, 2020

lhr0909 commented Jul 8, 2020

lhr0909 commented Jul 9, 2020

kjvalencik Jul 9, 2020

amilajack Jul 10, 2020

lhr0909 commented Jul 9, 2020

amilajack Jul 10, 2020 •

edited

Loading

lhr0909 commented Jul 12, 2020

dherman commented Jul 12, 2020

dherman commented Jul 12, 2020

lhr0909 commented Jul 12, 2020

dherman commented Jul 13, 2020

lhr0909 commented Jul 18, 2020

lhr0909 commented Jul 18, 2020 •

edited

Loading

lhr0909 commented Jul 18, 2020 •

edited

Loading

kjvalencik commented Jul 18, 2020

dherman left a comment

dherman Jul 18, 2020

kjvalencik Jul 18, 2020

amilajack commented Jul 18, 2020

lhr0909 commented Jul 19, 2020

dherman commented Aug 1, 2020

kjvalencik commented Aug 1, 2020 •

edited

Loading

kjvalencik commented Aug 1, 2020

kjvalencik commented Aug 1, 2020

dherman commented Aug 1, 2020

Switch to GitHub Actions #531

Switch to GitHub Actions #531

Conversation

lhr0909 commented Jun 21, 2020 • edited Loading

lhr0909 commented Jun 21, 2020

amilajack commented Jul 3, 2020

lhr0909 commented Jul 8, 2020

lhr0909 commented Jul 9, 2020

kjvalencik Jul 9, 2020

Choose a reason for hiding this comment

amilajack Jul 10, 2020

Choose a reason for hiding this comment

lhr0909 commented Jul 9, 2020

amilajack Jul 10, 2020 • edited Loading

Choose a reason for hiding this comment

lhr0909 commented Jul 12, 2020

dherman commented Jul 12, 2020

dherman commented Jul 12, 2020

lhr0909 commented Jul 12, 2020

dherman commented Jul 13, 2020

lhr0909 commented Jul 18, 2020

lhr0909 commented Jul 18, 2020 • edited Loading

lhr0909 commented Jul 18, 2020 • edited Loading

kjvalencik commented Jul 18, 2020

dherman left a comment

Choose a reason for hiding this comment

dherman Jul 18, 2020

Choose a reason for hiding this comment

kjvalencik Jul 18, 2020

Choose a reason for hiding this comment

amilajack commented Jul 18, 2020

lhr0909 commented Jul 19, 2020

dherman commented Aug 1, 2020

kjvalencik commented Aug 1, 2020 • edited Loading

kjvalencik commented Aug 1, 2020

kjvalencik commented Aug 1, 2020

dherman commented Aug 1, 2020

lhr0909 commented Jun 21, 2020 •

edited

Loading

amilajack Jul 10, 2020 •

edited

Loading

lhr0909 commented Jul 18, 2020 •

edited

Loading

lhr0909 commented Jul 18, 2020 •

edited

Loading

kjvalencik commented Aug 1, 2020 •

edited

Loading