Use FunctionTemplate instead of Function for adding methods to a class #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #119, which was causing hard crashes on newer versions of node. Signed-off-by: Nathan Sobo <nathan@github.com>
|
📟 @dherman |
dherman
approved these changes
Jan 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the commit from #123 that resolves #119. I fixed a minor merge conflict with master and added a doc comment for the
fun::new_templatefunction.I also looked at the possibility of using
Nan::SetMethodbut it didn't seem like the right solution in this case.I tested this on linux with node 4, 6, and 7.