-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8::ObjectTemplate::Set() with non-primitive values is deprecated #119
Comments
Here's how Nan fixed it: nodejs/nan@a90951e. |
+1 |
Fixes neon-bindings#119, which was causing hard crashes on newer versions of node.
Fixes neon-bindings#119, which was causing hard crashes on newer versions of node. Signed-off-by: Nathan Sobo <nathan@github.com>
Thanks for creating an issue. I've confirmed this shows up with node 6. This error doesn't show up for node 4 and I get the following error when running with node 7 (not sure if it's a different issue yet):
I'm going to looking into the Nan solution and also see what #123 did to address this and try to land the fix. |
@jedireza It's the same issue. Node v7 no longer prints the warning, it's a hard error now. |
v8::ObjectTemplate::Set() with non-primitive values is deprecated
is thrown when setting a buffer as a key of an object.for code:
Then require the library.
🍻
The text was updated successfully, but these errors were encountered: